Skip to content

chore(deps): upgrade integration test dependencies to reduce deprecations #1939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
inlined wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): upgrade integration test dependencies to reduce deprecations #1939

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion integration_test/package.json.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"build": "./node_modules/.bin/tsc"
},
"dependencies": {
"@google-cloud/pubsub": "^2.10.0",
"@google-cloud/pubsub": "^4.8.0",
"firebase-admin": "__FIREBASE_ADMIN__",
"firebase-functions": "__SDK_TARBALL__"
},
Expand Down
2 changes: 1 addition & 1 deletion integration_test/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ build_sdk
delete_all_functions

for version in 22 24; do
create_package_json $TIMESTAMP $version "^10.0.0"
create_package_json $TIMESTAMP $version "^12.0.0"

@gemini-code-assist gemini-code-assist Bot Jul 24, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In Bash, it is best practice to double-quote variable expansions to prevent word splitting and globbing, even if the variables currently do not contain spaces.

Suggested change
create_package_json $TIMESTAMP $version "^12.0.0"
create_package_json "$TIMESTAMP" "$version" "^12.0.0"

install_deps
announce "Re-deploying the same functions to Node $version runtime ..."
deploy
Expand Down
Loading