chore(deps): upgrade integration test dependencies to reduce deprecations#1939
Open
inlined wants to merge 1 commit into
Open
chore(deps): upgrade integration test dependencies to reduce deprecations#1939inlined wants to merge 1 commit into
inlined wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the @google-cloud/pubsub dependency version in the integration test template and bumps a version argument in the test runner script. The review feedback suggests double-quoting variable expansions in the Bash script to prevent word splitting and globbing.
|
|
||
| for version in 22 24; do | ||
| create_package_json $TIMESTAMP $version "^10.0.0" | ||
| create_package_json $TIMESTAMP $version "^12.0.0" |
Contributor
There was a problem hiding this comment.
In Bash, it is best practice to double-quote variable expansions to prevent word splitting and globbing, even if the variables currently do not contain spaces.
Suggested change
| create_package_json $TIMESTAMP $version "^12.0.0" | |
| create_package_json "$TIMESTAMP" "$version" "^12.0.0" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Audit & Remediation: firebase-functions integration tests
A. Previous CVEs
glob@8.1.0(inflight@1.0.6)@google-cloud/pubsub@^2.10.0firebase-admin@^10.0.0B. Changes Made
@google-cloud/pubsubfrom^2.10.0to^4.8.0inintegration_test/package.json.template.firebase-adminfrom^10.0.0to^12.0.0inintegration_test/run_tests.sh.uuid,glob,lodashhelper packages).C. Remaining CVEs
D. Introduced CVEs
E. Testing Strategy
Release Notes
relnote: chore: upgrade integration test dependencies to reduce deprecations