Skip to content

chore: update GoogleTest to v1.18.0 #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AustinBenoit merged 3 commits into from
Oct 27, 2026
+36 −32
Merged

chore: update GoogleTest to v1.18.0 #1948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe55754
chore: update GoogleTest to v1.18.0 (063de7e9578f82b369302001269680b4…
AustinBenoit Oct 26, 2026
297dcdf
chore: update GoogleTest pin comments and remove redundant os.path.join
AustinBenoit Oct 26, 2026
eafb83f
Merge branch 'main' into update-googletest-1.18.0
AustinBenoit Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions analytics/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions app/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions app_check/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions auth/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
7 changes: 4 additions & 3 deletions cmake/external/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,16 @@ if(TARGET googletest OR NOT DOWNLOAD_GOOGLETEST)
return()
endif()

set(version 1.11.0) # June 2021
# Pin to the v1.18.0 commit hash (August 2026) to ensure the tag does not change.
set(version 063de7e9578f82b369302001269680b4b1553359)

ExternalProject_Add(
googletest

DOWNLOAD_DIR ${FIREBASE_DOWNLOAD_DIR}
DOWNLOAD_NAME googletest-${version}.tar.gz
URL https://github.com/google/googletest/archive/release-${version}.tar.gz
URL_HASH SHA256=b4870bf121ff7795ba20d20bcdd8627b8e088f2d1dab299a031c1034eddc93d5
URL https://github.com/google/googletest/archive/${version}.tar.gz
URL_HASH SHA256=623fe05d283020f37a579a8985ba338091ac7229da62b5591ff40acdf05b95e2

PREFIX ${PROJECT_BINARY_DIR}

Expand Down
4 changes: 2 additions & 2 deletions database/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions firestore/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions firestore/integration_test_internal/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions functions/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions installations/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions messaging/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions remote_config/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
4 changes: 2 additions & 2 deletions storage/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
9 changes: 6 additions & 3 deletions testing/test_framework/download_googletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,13 @@
SRC_DIR = os.path.relpath(os.path.dirname(__file__))
TAG = os.path.basename(__file__)

# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
GOOGLETEST_ZIP = 'https://github.com/google/googletest/archive/refs/tags/release-1.11.0.zip'
# Pin to the v1.18.0 commit hash to ensure the tag does not change.
GOOGLETEST_COMMIT = '063de7e9578f82b369302001269680b4b1553359'
GOOGLETEST_ZIP = (
'https://github.com/google/googletest/archive/%s.zip' % GOOGLETEST_COMMIT
)
# Top-level directory inside the zip file to ignore.
GOOGLETEST_DIR = os.path.join('googletest-release-1.11.0')
GOOGLETEST_DIR = 'googletest-%s' % GOOGLETEST_COMMIT

# The GoogleTest code is copied into this subdirectory.
# This structure matches where the files are placed by CMake.
Expand Down
4 changes: 2 additions & 2 deletions ump/integration_test/googletest.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
# limitations under the License.

# Download GoogleTest from GitHub as an external project.
# Pin to 1.11.0 because we touch internal GoogleTest structures that could change in the future.
# Pin to the v1.18.0 commit hash to ensure the tag does not change.

# This CMake file is taken from:
# https://github.com/google/googletest/blob/master/googletest/README.md#incorporating-into-an-existing-cmake-project
Expand All @@ -25,7 +25,7 @@ project(googletest-download NONE)
include(ExternalProject)
ExternalProject_Add(googletest
GIT_REPOSITORY https://github.com/google/googletest.git
GIT_TAG "release-1.11.0"
GIT_TAG "063de7e9578f82b369302001269680b4b1553359"
SOURCE_DIR "${CMAKE_CURRENT_BINARY_DIR}/src"
BINARY_DIR "${CMAKE_CURRENT_BINARY_DIR}/build"
CONFIGURE_COMMAND ""
Expand Down
Loading