Repository navigation
chore: update GoogleTest to v1.18.0 - #1948
Merged
Merged
Conversation
AustinBenoit
added
the
tests-requested: full
github-actions
Bot
added
tests: in-progress
❌ Integration test FAILEDRequested by @AustinBenoit on commit 0c318c8
Add flaky tests to go/fpl-cpp-flake-tracker |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the GoogleTest dependency across various integration test directories and download scripts, pinning it to a specific commit hash (063de7e9578f82b369302001269680b4b1553359) instead of the older release-1.11.0 tag. The feedback suggests a minor code simplification in the Python download script to remove a redundant os.path.join call.
AustinBenoit
added
tests-requested: full
github-actions
Bot
removed
the
tests-requested: full
AustinBenoit
added
tests-requested: full
github-actions
Bot
added
tests: in-progress
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
a-maurice
approved these changes
Oct 26, 2026
Contributor
Author
|
The test failure aren't related to the library update. (I think) |
AustinBenoit
added
tests: succeeded
github-actions
Bot
added
tests: in-progress
firebase-workflow-trigger
Bot
removed
the
tests: in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update GoogleTest from
1.11.0to the latest releasev1.18.0, pinned to its release commit hash (063de7e9578f82b369302001269680b4b1553359), across:cmake/external/googletest.cmake(SDK unit tests, including updated archive URL and SHA256 hash)*/integration_test*/googletest.cmake(standalone CMake integration test projects)testing/test_framework/download_googletest.py(iOS/macOS integration test downloader)This is a test-only dependency update with zero SDK binary impact.
Testing
Planning on testing with GitHub Actions using the
tests-requested: fulllabel to kick off the full integration test matrix.Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.