-
-
Notifications
You must be signed in to change notification settings - Fork 507
Fix Sessions grid column overlap #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ejsmith
wants to merge
6
commits into
main
Choose a base branch
from
issue/sessions-grid-column-overlap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bbb49cc
Fix Sessions grid column overlap
ejsmith 45cca25
Merge branch 'main' into issue/sessions-grid-column-overlap
ejsmith 5114bef
Preserve flexible column resizing
ejsmith 2122676
Merge remote-tracking branch 'origin/main' into issue/sessions-grid-c…
ejsmith 4112d27
Update flexible column E2E sizing
ejsmith 78975bf
Preserve flexible width on resize clicks
ejsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
...tionless.Web/ClientApp/src/lib/features/sessions/components/session-table-columns.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| import { describe, expect, it } from 'vitest'; | ||
|
|
||
| import { getSessionColumns } from './session-table-columns'; | ||
|
|
||
| describe('getSessionColumns', () => { | ||
| it('marks Summary as the flexible full-width column', () => { | ||
| const summaryColumn = getSessionColumns().find((column) => column.id === 'summary'); | ||
|
|
||
| expect(summaryColumn).toMatchObject({ | ||
| header: 'Summary', | ||
| meta: { | ||
| class: 'w-full' | ||
| } | ||
| }); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a user presses and releases the resize handle without moving it, this immediately writes the rendered width into the persisted column-sizing state. For the flexible
w-fullcolumn, that makesgetFlexibleDataColumnId()stop treating the column as flexible, so a simple click permanently converts it to a fixed-width column and later viewport resizing can leave unused space or introduce horizontal overflow. The size should only be committed after an actual drag, while still using the rendered width as the drag's starting point.Useful? React with 👍 / 👎.