Fix Sessions grid column overlap - #2465
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 212267602f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| table.setColumnSizing((current) => ({ | ||
| ...current, | ||
| [header.column.id]: currentSize | ||
| })); |
There was a problem hiding this comment.
When a user presses and releases the resize handle without moving it, this immediately writes the rendered width into the persisted column-sizing state. For the flexible w-full column, that makes getFlexibleDataColumnId() stop treating the column as flexible, so a simple click permanently converts it to a fixed-width column and later viewport resizing can leave unused space or introduce horizontal overflow. The size should only be committed after an actual drag, while still using the rendered width as the drag's starting point.
Useful? React with 👍 / 👎.
|
1 participant
What changed
w-fullcolumn when the shared table chooses which unsized column should fill the remaining width.Why
The shared fixed-layout table treated the last unsized column as flexible. On the Sessions grid that made Date consume the remaining width and collapsed Summary, causing the Summary and Duration headers to overlap.
Verification
npm run validatenpm run test:unit -- src/lib/features/shared/components/data-table/data-table-body.svelte.test.ts src/lib/features/sessions/components/session-table-columns.test.ts(2 files, 9 tests)Breaking changes
None.