fix(commerce-elastic-path): requote from the managed form when the update returns no rates - #599
Merged
Merged
Conversation
…date returns no rates The loader bundle ships one package version to every app host, while each host's server routes stay on the version it installed. A host on an older server clears the rates on an address change and does not requote, so the new form left its shopper with no rate to pick and /pay failed. The form now requotes once when the update comes back with an empty rate list. Against a current server the update already carries the rates, so it still sends one request per address change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loader bundle gives every app host the same package version, but each host's server routes stay on the version it installed. After #597, the managed form stopped requesting rates, because the update now returns them. A host still on an older server gets an address with no rates, so the shopper can't pick one and
/payfails.The form now calls the requote once when the update returns an empty rate list. A current server returns the rates with the update, so it still sends one request per address change.
This keeps the next loader bump safe for app hosts that haven't upgraded their own server code yet.