Skip to content

Enable MSBuild node reuse defaults in the F# build scripts #20220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
T-Gro wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −5
Open

Enable MSBuild node reuse defaults in the F# build scripts #20220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions eng/Build.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,8 +165,6 @@ function Process-Arguments() {
$script:useGlobalNugetCache = $False
}

$script:nodeReuse = $False;

if ($testAll) {
$script:testDesktop = $True
$script:testCoreClr = $True
Expand Down
3 changes: 0 additions & 3 deletions eng/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,9 +303,6 @@ function BuildSolution {
quiet_restore=true
fi

# Node reuse fails because multiple different versions of FSharp.Build.dll get loaded into MSBuild nodes
node_reuse=false

# build bootstrap tools
# source_build=In source build proto does no work, except cause sourcebuild in wrapper to build
bootstrap_dir=$artifacts_dir/Bootstrap
Expand Down
Loading