Enable MSBuild node reuse defaults in the F# build scripts - #20220
Open
T-Gro wants to merge 1 commit into
Open
Conversation
Both entry points hard-disabled MSBuild node reuse for every build, overriding Arcade's default (node reuse on locally, off on CI). The overrides were added together in March 2019 (7a6448e, f4bd221) as a workaround for FSharp.Build.dll version conflicts when the proto compiler and the freshly built one are loaded into reused MSBuild nodes during F#'s self-bootstrap. This removes both overrides so Arcade's default applies, restoring node reuse for the inner loop and unblocking MSBuild Server. Whether the 2019 FSharp.Build.dll conflict still reproduces is validated by full CI, including the Windows EndToEndBuildTests job, which builds without -ci and therefore now exercises node reuse end to end. Fixes #20217 Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
✅ No release notes required |
github-actions
Bot
added
the
AI-Tooling-Check-Bypassed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #20217
eng/Build.ps1andeng/build.shboth hard-disabled MSBuild node reuse for every build, overriding Arcade's default (reuse on locally, off on CI). The overrides were added together in March 2019 as a workaround forFSharp.Build.dllversion conflicts when the proto compiler and the freshly built one land in reused MSBuild nodes during F#'s self-bootstrap — not, as the issue assumed, a PowerShell-only template leftover.Removing both restores node reuse for the inner loop and unblocks MSBuild Server. Whether that 2019
FSharp.Build.dllconflict still reproduces is the open question, so this leans on full CI to answer it — in particular the WindowsEndToEndBuildTestsjob, which builds without-ciand now exercises node reuse end to end.