Remove always-on UseBindingValueDiscard language feature flag

src/Compiler/Checking/Expressions/CheckExpressions.fs

@@ -12210,11 +12210,9 @@ and TcLetBinding (cenv: cenv) isUse env containerInfo declKind tpenv (synBinds,
                 let tmp, _ = mkCompGenLocal m "patternInput" (generalizedTypars +-> tauTy)
 
                 if isUse then
-                    let isDiscarded = match checkedPat with TPat_wild _ -> true | _ -> false
-                    if not isDiscarded then
-                        errorR(Error(FSComp.SR.tcInvalidUseBinding(), m))
-                    else
-                        checkLanguageFeatureAndRecover g.langVersion LanguageFeature.UseBindingValueDiscard checkedPat.Range
+                    match checkedPat with
+                    | TPat_wild _ -> ()
+                    | _ -> errorR(Error(FSComp.SR.tcInvalidUseBinding(), m))
 
                 elif isFixed then
                     errorR(Error(FSComp.SR.tcInvalidUseBinding(), m))

src/Compiler/FSComp.txt

@@ -1248,7 +1248,6 @@ featureOverloadsForCustomOperations,"overloads for custom operations"
 featureExpandedMeasurables,"more types support units of measure"
 featureIndexerNotationWithoutDot,"expr[idx] notation for indexing and slicing"
 featureRefCellNotationInformationals,"informational messages related to reference cells"
-featureDiscardUseValue,"discard pattern in use binding"
 featureNonVariablePatternsToRightOfAsPatterns,"non-variable patterns to the right of 'as' patterns"
 featureAttributesToRightOfModuleKeyword,"attributes to the right of the 'module' keyword"
 featureBetterExceptionPrinting,"automatic generation of 'Message' property for 'exception' declarations"

src/Compiler/Facilities/LanguageFeatures.fs

@@ -41,7 +41,6 @@ type LanguageFeature =
     | StructActivePattern
     | IndexerNotationWithoutDot
     | RefCellNotationInformationals
-    | UseBindingValueDiscard
     | UnionIsPropertiesVisible
     | NonVariablePatternsToRightOfAsPatterns
     | AttributesToRightOfModuleKeyword
@@ -179,7 +178,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
                 LanguageFeature.StructActivePattern, languageVersion60
                 LanguageFeature.IndexerNotationWithoutDot, languageVersion60
                 LanguageFeature.RefCellNotationInformationals, languageVersion60
-                LanguageFeature.UseBindingValueDiscard, languageVersion60
                 LanguageFeature.NonVariablePatternsToRightOfAsPatterns, languageVersion60
                 LanguageFeature.AttributesToRightOfModuleKeyword, languageVersion60
                 LanguageFeature.DelegateTypeNameResolutionFix, languageVersion60
@@ -389,7 +387,6 @@ type LanguageVersion(versionText, ?disabledFeaturesArray: LanguageFeature array)
         | LanguageFeature.StructActivePattern -> FSComp.SR.featureStructActivePattern ()
         | LanguageFeature.IndexerNotationWithoutDot -> FSComp.SR.featureIndexerNotationWithoutDot ()
         | LanguageFeature.RefCellNotationInformationals -> FSComp.SR.featureRefCellNotationInformationals ()
-        | LanguageFeature.UseBindingValueDiscard -> FSComp.SR.featureDiscardUseValue ()
         | LanguageFeature.UnionIsPropertiesVisible -> FSComp.SR.featureUnionIsPropertiesVisible ()
         | LanguageFeature.NonVariablePatternsToRightOfAsPatterns -> FSComp.SR.featureNonVariablePatternsToRightOfAsPatterns ()
         | LanguageFeature.AttributesToRightOfModuleKeyword -> FSComp.SR.featureAttributesToRightOfModuleKeyword ()

src/Compiler/Facilities/LanguageFeatures.fsi

@@ -31,7 +31,6 @@ type LanguageFeature =
     | StructActivePattern
     | IndexerNotationWithoutDot
     | RefCellNotationInformationals
-    | UseBindingValueDiscard
     | UnionIsPropertiesVisible
     | NonVariablePatternsToRightOfAsPatterns
     | AttributesToRightOfModuleKeyword