Sign the Microsoft.SqlServer.Server assembly and wire its package CI

[paulmedynski]

Summary

Aligns the Microsoft.SqlServer.Server signing comment with the assembly-signing terminology and wires the SqlServer.Server package CI stage/job for signed internal builds.

🔗 PR Stack

Part of a 5-PR stack — current PR marked 👉. Indentation shows the branch base.

• 🏗️ #4382 — Sign CI Package pipeline assemblies & tests · base: main
  • 🏷️ #4383 — Rename STRONG_NAME_SIGNING → ASSEMBLY_SIGNING
    • 🪵 #4384 — Add Logging test package & CI
    • ☁️ #4385 — Sign Azure extension assembly & tests
    • 🧩 👉 #4386 — Sign Microsoft.SqlServer.Server assembly & CI

flowchart TD
    main([main])
    PR1["🏗️ #4382<br/>signing-core"]
    PR2["🏷️ #4383<br/>rename"]
    PR3["🪵 #4384<br/>logging-tests"]
    PR4["☁️ #4385<br/>azure-signing"]
    PR5["🧩 #4386<br/>sqlserver.server"]
    main --> PR1 --> PR2
    PR2 --> PR3
    PR2 --> PR4
    PR2 --> PR5
    click PR1 "https://github.com/dotnet/SqlClient/pull/4382" _blank
    click PR2 "https://github.com/dotnet/SqlClient/pull/4383" _blank
    click PR3 "https://github.com/dotnet/SqlClient/pull/4384" _blank
    click PR4 "https://github.com/dotnet/SqlClient/pull/4385" _blank
    click PR5 "https://github.com/dotnet/SqlClient/pull/4386" _blank
    classDef current fill:#1f6feb,stroke:#1f6feb,color:#fff;
    class PR5 current;

Loading

Checklist

• Signed + unsigned compile verified
• Public API changes documented (none)
• No breaking changes

[Copilot]

Pull request overview

This PR aligns SqlServer.Server’s project comment terminology with the repo-wide “assembly signing” language, and wires the SqlServer.Server CI stage/job to support signed internal (ADO.Net) builds by threading isInternalBuild and referenceType through the CI templates and conditionally supplying SigningKeyPath during pack.

Changes:

• Update Microsoft.SqlServer.Server.csproj comment to “Assembly signing”.
• Add isInternalBuild and referenceType parameters to the SqlServer package CI stage and pass them into the pack job.
• In the SqlServer pack job, conditionally download the signing key and include SigningKeyPath in dotnet pack build properties for internal Package-mode builds.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
src/Microsoft.SqlServer.Server/Microsoft.SqlServer.Server.csproj	Renames the signing comment to match “assembly signing” terminology used elsewhere.
eng/pipelines/stages/build-sqlserver-package-ci-stage.yml	Adds isInternalBuild/referenceType parameters and forwards them to the pack job.
eng/pipelines/jobs/pack-sqlserver-package-ci-job.yml	Adds conditional signing-key download and SigningKeyPath injection for internal Package-mode packs.
eng/pipelines/dotnet-sqlclient-ci-core.yml	Threads isInternalBuild and referenceType into the SqlServer package stage invocation.