Rename STRONG_NAME_SIGNING to ASSEMBLY_SIGNING#4383
Draft
paulmedynski wants to merge 1 commit into
Draft
Conversation
Rename the conditional-compilation constant from STRONG_NAME_SIGNING to ASSEMBLY_SIGNING and align comments, log messages, and documentation from "strong name" to "assembly signing" terminology across the shared build configuration, SqlClient source, and tests.
This was referenced Jun 19, 2026
3 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Terminology-only rename across the repo to standardize on ASSEMBLY_SIGNING (replacing STRONG_NAME_SIGNING) and to update surrounding “strong name” wording to “assembly signing” / “strong-name identity” phrasing, covering MSBuild props, source, project files, tests, and pipeline docs.
Changes:
- Rename conditional compilation constant
STRONG_NAME_SIGNING→ASSEMBLY_SIGNINGand update call sites. - Update MSBuild/pipeline/project comments to “Assembly signing” terminology.
- Update test comments around the
signedtrait to avoid “strong-name signed” phrasing.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Microsoft.Data.SqlClient/tests/UnitTests/Microsoft.Data.SqlClient.UnitTests.csproj | Rename signing section comment to “Assembly signing”. |
| src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/Microsoft.Data.SqlClient.TestUtilities.csproj | Rename signing section comment to “Assembly signing”. |
| src/Microsoft.Data.SqlClient/tests/ManualTests/SQL/UdtTest/SqlServerTypesTest.cs | Update signed category comments to “signed assembly” wording. |
| src/Microsoft.Data.SqlClient/tests/FunctionalTests/SqlDataRecordTest.cs | Update signed category comments to “signed assembly” wording. |
| src/Microsoft.Data.SqlClient/tests/Common/Microsoft.Data.SqlClient.TestCommon.csproj | Rename signing section comment to “Assembly signing”. |
| src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationProviderManager.cs | Switch #if guard to ASSEMBLY_SIGNING and adjust log/comment wording. |
| src/Microsoft.Data.SqlClient/src/Microsoft.Data.SqlClient.csproj | Rename signing section header to “Assembly signing”. |
| src/Microsoft.Data.SqlClient/ref/Microsoft.Data.SqlClient.csproj | Rename signing section header to “Assembly signing”. |
| src/Microsoft.Data.SqlClient/notsupported/Microsoft.Data.SqlClient.csproj | Rename signing section header to “Assembly signing”. |
| src/Microsoft.Data.SqlClient.Extensions/Abstractions/test/Abstractions.Test.csproj | Rename signing section header to “Assembly signing”. |
| src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/SqlAuthenticationProvider.Internal.cs | Switch #if guard to ASSEMBLY_SIGNING and adjust comments. |
| src/Microsoft.Data.SqlClient.Extensions/Abstractions/src/Abstractions.csproj | Rename signing section header to “Assembly signing”. |
| src/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider/src/Microsoft.Data.SqlClient.AlwaysEncrypted.AzureKeyVaultProvider.csproj | Rename signing section header to “Assembly signing”. |
| src/Directory.Build.props | Define ASSEMBLY_SIGNING when SigningKeyPath is set; update comments. |
| eng/pipelines/onebranch/steps/build-buildproj-step.yml | Update documentation comment to “always signs”. |
| eng/pipelines/ci/package/sqlclient-package.yml | Update documentation comment to “assembly signing key”. |
| build.proj | Update SigningKeyPath and signed-test filter documentation wording. |
|
|
||
| <!-- Strong name signing ============================================= --> | ||
| <!-- Assembly signing ============================================= --> | ||
| <!-- Strong naming is being done in Directory.Build.props --> |
Comment on lines
248
to
+251
| SigningKeyPath | ||
| Applies to: Build*, Pack* | ||
| Description: Path to the key to use to strong name sign binaries. If omitted, binaries | ||
| will not be strong name signed. | ||
| Description: Path to the key to use to sign driver assemblies. If omitted, driver | ||
| assemblies will not be signed. |
Comment on lines
320
to
322
| Exclude tests in the "signed" category when building unsigned assemblies. We have some tests | ||
| that require signed assemblies, and they would fail with strong name validation exceptions on | ||
| that require signed assemblies, and they would fail with assembly validation exceptions on | ||
| .NET Framework. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure terminology rename:
STRONG_NAME_SIGNING→ASSEMBLY_SIGNING(and related "strong name" wording → "assembly signing" / "strong-name identity") acrosssrc/Directory.Build.props, source files, csproj files, and pipeline YAML.No functional change — this only renames the conditional-compilation constant and aligns comments/wording.
🔗 PR Stack
Part of a 5-PR stack — current PR marked 👉. Indentation shows the branch base.
mainSTRONG_NAME_SIGNING→ASSEMBLY_SIGNINGMicrosoft.SqlServer.Serverassembly & CIflowchart TD main([main]) PR1["🏗️ #4382<br/>signing-core"] PR2["🏷️ #4383<br/>rename"] PR3["🪵 #4384<br/>logging-tests"] PR4["☁️ #4385<br/>azure-signing"] PR5["🧩 #4386<br/>sqlserver.server"] main --> PR1 --> PR2 PR2 --> PR3 PR2 --> PR4 PR2 --> PR5 click PR1 "https://github.com/dotnet/SqlClient/pull/4382" _blank click PR2 "https://github.com/dotnet/SqlClient/pull/4383" _blank click PR3 "https://github.com/dotnet/SqlClient/pull/4384" _blank click PR4 "https://github.com/dotnet/SqlClient/pull/4385" _blank click PR5 "https://github.com/dotnet/SqlClient/pull/4386" _blank classDef current fill:#1f6feb,stroke:#1f6feb,color:#fff; class PR2 current;Checklist
STRONG_NAME_SIGNINGreferences remain