Skip to content

Disambiguate type display names in benchmark selection - #3211

Merged
timcassell merged 2 commits into
dotnet:masterfrom
sheddy123:feature/3202-disambiguate-benchmark-names
Jul 29, 2026
Merged

Disambiguate type display names in benchmark selection#3211
timcassell merged 2 commits into
dotnet:masterfrom
sheddy123:feature/3202-disambiguate-benchmark-names

Conversation

@sheddy123

@sheddy123 sheddy123 commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

#3202
Disambiguate type display names in benchmark selection

Added GetDisambiguatedDisplayNames to qualify ambiguous type names with namespaces. Updated UserInteraction to use these names for clearer benchmark selection and filtering. Added unit tests and supporting fixture classes to verify correct behavior.

image

Disambiguate type display names in benchmark selection

Added GetDisambiguatedDisplayNames to qualify ambiguous type names with namespaces. Updated UserInteraction to use these names for clearer benchmark selection and filtering. Added unit tests and supporting fixture classes to verify correct behavior.
@sheddy123

Copy link
Copy Markdown
Contributor Author

@dotnet-policy-service agree

@sheddy123 sheddy123 changed the title #3202 Disambiguate type display names in benchmark selection Disambiguate type display names in benchmark selection Jul 28, 2026
Comment thread src/BenchmarkDotNet/Extensions/ReflectionExtensions.cs Outdated
Updated logic to use the type's FullName property for display names when type names are ambiguous, instead of combining namespace and simple name. This ensures more accurate and consistent type identification.

@timcassell timcassell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sheddy123

@timcassell
timcassell merged commit 95d469d into dotnet:master Jul 29, 2026
11 checks passed
@timcassell timcassell added this to the v0.16.0 milestone Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Customize/Disambiguate Benchmark Fixture Names for BenchmarkSwitcher.Run()

2 participants