Repository navigation
Conversation
Make v1.7 the last v1 release, so the floating v1 tag can't cross into CLI 5. - Run the CLI with ignoreReturnCode, delete any stale output file first, and still load results. A missing results file still fails the job. A non-zero exit still fails it too, now after the results, issue, and PR steps. - Include stderr in crash diagnostics, since CLI 5 logs there. - Default version to 4. Refuse latest, and any version or range that can install 5 or later, with a pointer to @v2. Empty still means the local CLI. - Cap $RESULTS to fit GitHub's issue body limit, and link to the run. Fill issue tokens in one pass, so text inside the results stays literal. - Remove the exit_on_fail default. Empty means false, with a notice that v2 defaults it to true. Closes #80 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
The deprecated `ios` input description and the WDA cache retirement notice linked to doc-detective.com/docs/..., which redirects to the docs home and loses the anchor. Point both at docs.doc-detective.com. The `create_pr_on_change` and `create_issue_on_fail` descriptions said they were only valid for the "runTests" command, but the action has no `command` input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The README documented a `command` input (`runTests`/`runCoverage`) that action.yml never declared, and qualified two inputs with "Only valid if `command` is `runTests`". Remove both. Also make the `issue_body` default match action.yml, including the `$RUN_URL` token, and name the `record` step instead of the old `startRecording` action. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs: remove the command input from the v1 README
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The last planned v1 release. It keeps the floating
v1tag on CLI 4, and it stops a non-zero exit from losing results. Closes #80.ignoreReturnCode, deletes any stale output file first, and still loads results. The results, issue, and PR steps now run before a non-zero exit fails the job. A missing results file still fails the job right away.exit_on_fail:truekeeps failing throughsetFailed. Theaction.ymldefault is gone, so empty meansfalse, with acore.noticethat v2 defaults it totrue.version: defaults to4. It refuseslatest, and any version or range that can install 5 or later, such as5,^5,>=4,*, and4 || 5, with a pointer to@v2. Empty still means the locally linked CLI.$RESULTS: cut to fit GitHub's 65,536-character limit, with a link to the run. Tokens now fill in one pass, so$PROMPTor$&inside the results stays literal and can't grow the body after it's measured.main.ymlandtest-current-release.ymldefaultedversiontolatest, which would now be refused, so they default to4.Decisions to check
next, get a warning instead of a refusal, because the Action can't tell what they install without a registry call. Tags that read as a version, likev5-rc, are refused.semverfor one release. v2 deletes it. A bound like<5.0.0-rc.1refuses, which errs safe.Skipped
annotationsinput. Not trivial.package.jsonis already on@actions/core3,@actions/exec3, and@actions/github9.Testing
npm test: 36 pass, 0 fail.npm run typecheckpasses, anddist/is rebuilt.dist/index.json Windows with a stubnpx, covering exit 0, 1, and 2 withexit_on_failtrue, false, and unset, with and without failed specs, a stale output file, and refused versions. Each case gave the expected job result andresultsoutput.🤖 Generated with Claude Code