Skip to content

data: add china_office.db.zip (LFS)#2501

Merged
paul-nechifor merged 1 commit into
mainfrom
data/china_office
Jun 16, 2026
Merged

data: add china_office.db.zip (LFS)#2501
paul-nechifor merged 1 commit into
mainfrom
data/china_office

Conversation

@jeff-hykin

Copy link
Copy Markdown
Member

Adds the china_office recording (fastlio2_pcap/china_office.db.zip, ~4GB) tracked via git LFS. Data-only branch — no code changes.

paul-nechifor
paul-nechifor previously approved these changes Jun 16, 2026
@greptile-apps

greptile-apps Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR primarily adds the china_office LiDAR recording (~4 GB) to fastlio2_pcap/ via git LFS, but also bundles two unrelated changes that the PR description incorrectly characterises as "no code changes."

  • fastlio2_pcap/china_office.db.zip: git LFS pointer for the ~4 GB china_office dataset.
  • dimos/core/global_config.py: removes the robot_id field from GlobalConfig; confirmed no usages of global_config.robot_id remain in the codebase.
  • .codecov.yml: converts project: true / patch: true to bare-key (null) form and adds newfooter to the comment layout, aligning with Codecov YAML v2 schema conventions.

Confidence Score: 5/5

All three changes are safe to merge: the LFS pointer is data-only, the removed robot_id field has no callers in the codebase, and the Codecov config update is non-functional.

The LFS file is a data asset with no code impact. The robot_id removal from GlobalConfig is confirmed clean — no code reads global_config.robot_id anywhere in the repo. The Codecov YAML adjustments are cosmetic/config-only and do not affect runtime behaviour.

No files require special attention.

Important Files Changed

Filename Overview
fastlio2_pcap/china_office.db.zip New git LFS pointer (~4 GB) for the china_office recording; no binary content in the repo itself.
dimos/core/global_config.py Removes the unused `robot_id: str
.codecov.yml Converts project: true / patch: true to bare keys (null), and appends newfooter to the comment layout — aligns with Codecov YAML v2 schema defaults.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR #2501] --> B[fastlio2_pcap/china_office.db.zip]
    A --> C[dimos/core/global_config.py]
    A --> D[.codecov.yml]

    B --> B1[git LFS pointer\n~4 GB china_office recording]

    C --> C1[Remove robot_id field\nfrom GlobalConfig]
    C1 --> C2{Any usages of\nglobal_config.robot_id?}
    C2 -- No --> C3[Safe to remove]

    D --> D1[project: true → project:\npatch: true → patch:]
    D --> D2[Add 'newfooter' to\ncomment layout]
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[PR #2501] --> B[fastlio2_pcap/china_office.db.zip]
    A --> C[dimos/core/global_config.py]
    A --> D[.codecov.yml]

    B --> B1[git LFS pointer\n~4 GB china_office recording]

    C --> C1[Remove robot_id field\nfrom GlobalConfig]
    C1 --> C2{Any usages of\nglobal_config.robot_id?}
    C2 -- No --> C3[Safe to remove]

    D --> D1[project: true → project:\npatch: true → patch:]
    D --> D2[Add 'newfooter' to\ncomment layout]
Loading

Reviews (3): Last reviewed commit: "Merge branch 'data/china_office' of gith..." | Re-trigger Greptile

@paul-nechifor paul-nechifor enabled auto-merge (squash) June 16, 2026 01:15
Comment thread .gitattributes Outdated
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #2501      +/-   ##
==========================================
- Coverage   70.09%   69.96%   -0.14%     
==========================================
  Files         838      838              
  Lines       74337    74337              
  Branches     6667     6667              
==========================================
- Hits        52110    52013      -97     
- Misses      20552    20620      +68     
- Partials     1675     1704      +29     
Flag Coverage Δ
OS-ubuntu-24.04-arm 63.84% <ø> (+<0.01%) ⬆️
OS-ubuntu-latest 64.66% <ø> (ø)
Py-3.10 64.66% <ø> (+<0.01%) ⬆️
Py-3.11 64.66% <ø> (-0.01%) ⬇️
Py-3.12 64.66% <ø> (+<0.01%) ⬆️
Py-3.13 64.66% <ø> (-0.01%) ⬇️
Py-3.14 64.67% <ø> (+<0.01%) ⬆️
Py-3.14t 64.66% <ø> (ø)
SelfHosted-Large 30.27% <ø> (-0.08%) ⬇️
SelfHosted-Linux 38.20% <ø> (-0.01%) ⬇️
SelfHosted-macOS 36.97% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Jun 16, 2026
@jeff-hykin jeff-hykin force-pushed the data/china_office branch 2 times, most recently from 0c049f9 to fc0b026 Compare June 16, 2026 02:34
@github-actions github-actions Bot added the ready-to-merge Required CI checks have passed on this PR label Jun 16, 2026
@leshy

leshy commented Jun 16, 2026

Copy link
Copy Markdown
Member

wait why .zip? .tar.gz will auto compress this before pushing to lfs, no need for zip

/china_office.db.zip.tar.gz

Unpacked db (9.38 GB) tarred to data/.lfs/china_office.db.tar.gz (4.06 GB,
2.31x). Replaces the earlier double-compressed china_office.db.zip.tar.gz.
@github-actions github-actions Bot added ready-to-merge Required CI checks have passed on this PR and removed ready-to-merge Required CI checks have passed on this PR labels Jun 16, 2026
@paul-nechifor paul-nechifor merged commit 3eee819 into main Jun 16, 2026
26 of 27 checks passed
@paul-nechifor paul-nechifor deleted the data/china_office branch June 16, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Required CI checks have passed on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants