Build/cache native modules#2470
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Greptile SummaryThis PR wires up a new
Confidence Score: 4/5Safe to merge once the macOS test-blocking dependency is addressed; the remaining findings are low-impact edge cases. The macOS self_hosted matrix variant is now coupled to nav-stack-natives even though it never installs Nix or fetches native modules. A Cachix auth failure or nix build timeout would cancel the macOS run entirely, silently dropping coverage that has no dependency on native builds. ci.yml — the needs: [compute-ros-pin, nav-stack-natives] line on self-hosted-tests couples both matrix variants to native module availability. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into sam/native-modu..." | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Problem
nav_stack tests are being skipped due to lack of native modules.
Solution
Build the modules in CI, cache the nix build in Cachix.