feat: add werf deploy-dependency on controller to ValidatingWebhookConfiguration#203
Merged
Merged
Conversation
…nfiguration The generated ValidatingWebhookConfiguration referenced the webhook-serving controller Service without any ordering guarantee, so werf could apply it before the controller Deployment was ready — causing admission failures for matching resources during rollout. Add a werf.io/deploy-dependency-controller annotation so the webhook configuration is deployed only after the controller Deployment is Ready. The controller Deployment name is configurable via the new controllerName config parameter (default: "controller"). Bump chart version to 1.72.8. Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
ilya-lesikov
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
werf.io/deploy-dependency-controllerannotation to theValidatingWebhookConfigurationgenerated byhelm_lib_module_validating_webhook_configuration.Why
The generated
ValidatingWebhookConfigurationpoints at the webhook-serving controllerServicebut had no ordering guarantee. During a rollout werf could apply the webhook configuration before the controllerDeploymentbecameReady, so any resource matching the webhook rules (e.g.StorageClasscreate/update) would fail admission until the backend came up.With the annotation, werf deploys the
ValidatingWebhookConfigurationonly after the controllerDeploymentreaches theReadystate.Changes
_module_controller.tpl: addwerf.io/deploy-dependency-controller: state=ready,kind=Deployment,name=<controllerName>,namespace=d8-<chart>to the webhook configuration metadata. New optionalcontrollerNameconfig parameter (default:controller, matching the defaultfullnameofhelm_lib_module_controller_manifests).Chart.yaml: bump chart version1.72.7->1.72.8.controllerNameoverride.Testing
helm unittest tests/— 346 tests passed, 81 suites.