feat: also gate ValidatingWebhookConfiguration on webhook Service presence#204
Merged
Merged
Conversation
…sence The ValidatingWebhookConfiguration already depended on the controller Deployment being Ready, but werf could still apply it before the webhook Service existed, leaving admission requests without a routable backend. Add a werf.io/deploy-dependency-service annotation (state=present) referencing the webhook Service (serviceName) so the configuration is deployed only after both the controller Deployment is Ready and the Service is present. Bump chart version to 1.72.9. Signed-off-by: v.oleynikov <vasily.oleynikov@flant.com>
NikolayDemchuk
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a second
werf.io/deploy-dependency-serviceannotation to theValidatingWebhookConfigurationgenerated byhelm_lib_module_validating_webhook_configuration, gating it on the webhookServicebeing present.Why
Follow-up to #203. That change made the webhook configuration wait for the controller
Deploymentto becomeReady, but werf could still apply theValidatingWebhookConfigurationbefore the webhookServiceexisted. In that window admission requests have no routable backend behindclientConfig.service.The configuration must be deployed only after both the controller
DeploymentisReadyand the webhookServiceis present.Changes
_module_controller.tpl: addwerf.io/deploy-dependency-service: state=present,kind=Service,name=<serviceName>,namespace=d8-<chart>alongside the existing controller dependency. Uses the existingserviceNameconfig parameter (default:webhooks).Chart.yaml: bump chart version1.72.8->1.72.9.serviceName.Testing
helm unittest tests/— 346 tests passed, 81 suites.