Repository navigation
acceptance: prepare plan and template comparisons for UUID numbering - #7423
Merged
Merged
Conversation
The built-in [UUID] replacement collapses every UUID to one token, so a golden cannot tell two distinct UUIDs apart (raised in review of #6995). Add a UniqueUUID test.toml knob (default false) that, when set, makes the built-in UUID replacement honor the existing Distinct numbering: distinct UUIDs in an output become [UUID][0], [UUID][1], ... in order of first appearance. Existing tests are unaffected (default off); a test opts in with UniqueUUID = true. Co-authored-by: Isaac <no-reply@databricks.com>
This was referenced Nov 9, 2026
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 7 not selected) 35 tests: regression=0 unreleased=0 coverage=35 failing=0
|
Collaborator
✅ Integration test reportCommit: d9d1f41
Top 3 slowest tests (at least 2 minutes):
|
denik
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Capture the immutable no-artifacts test's initial plan in a separate golden, preserving its assertions. Teach the Python replacement helper to honor
Distinctso template comparisons can match numbered goldens.Why
Saved-plan deployment reuses the planned snapshot UUID; direct deployment generates another. Separate plan output lets both variants share expectations. Template comparisons also need the same numbering behavior as the Go harness before #7021 removes the UUID opt-out.
Stacked on #7020. UUID numbering remains off by default in this PR.
Tests
Both immutable variants, template tests, and helper selftests passed with numbering off. Python doctests cover repeated values, multiple distinct values, and already-normalized output. Formatting, checks, lint, and the full test suite passed with numbering always enabled on the completed stack; #7021 records the transient retry.
This PR was written by Codex.