Repository navigation
acceptance: always distinguish UUIDs in test output - #7021
Merged
Merged
Conversation
github-actions
Bot
added
DABs
denik
previously approved these changes
Oct 12, 2026
| matches := repl.Old.FindAllString(s, -1) | ||
| if len(matches) <= 1 { | ||
| // Assign a stable [N] suffix per distinct matched value, in order of first | ||
| // appearance. Number only when there is more than one distinct value: a lone |
Contributor
There was a problem hiding this comment.
I'd send this change as separate PR, to separate all those diffs unrelate to UUIDs.
Member
Author
denik
reviewed
Oct 12, 2026
| "name": "schema-[UNIQUE_NAME]", | ||
| "owner": "[USERNAME]", | ||
| "schema_id": "[UUID]", | ||
| "updated_at": [UNIX_TIME_MILLIS][0], |
Member
Author
There was a problem hiding this comment.
created_at and updated_at contain the same timestamp, so there is only one distinct value. The generic change adds suffixes only when there are multiple distinct values; repeated occurrences of a single value stay unsuffixed. That behavior and these timestamp golden changes now live in #7420. This PR only adds UUID numbering to metastore_id and schema_id in this file.
Collaborator
✅ Integration test reportCommit: aedd90c
Top 14 slowest tests (at least 2 minutes):
|
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-knob
branch
from
November 9, 2026 22:54
26ab8ff to
fc3f149
Compare
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 9, 2026 22:54
767640b to
8fabaa1
Compare
Contributor
|
Commit: Regression test reportSelected 20 changed tests (limit=20, 76 not selected) 25 tests: regression=0 unreleased=0 coverage=25 failing=0
|
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-knob
branch
from
November 9, 2026 23:30
fc3f149 to
5c0a683
Compare
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 9, 2026 23:30
8fabaa1 to
4190d12
Compare
janniklasrose
changed the base branch from
janniklasrose/acc/uuid-unique-knob
to
janniklasrose/acc/uuid-compatible-tests
November 9, 2026 23:31
janniklasrose
changed the title
janniklasrose
marked this pull request as ready for review
November 10, 2026 09:58
denik
approved these changes
Nov 10, 2026
denik
left a comment
denik
left a comment
Contributor
There was a problem hiding this comment.
Can you test this for flakiness? For example, by pushing 5 empty commits one after another.
Base automatically changed from
janniklasrose/acc/uuid-compatible-tests
to
main
November 10, 2026 12:06
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 10, 2026 12:06
a67dc51 to
95981fe
Compare
janniklasrose
force-pushed
the
janniklasrose/acc/uuid-unique-on-by-default
branch
from
November 10, 2026 15:20
21ca39e to
aedd90c
Compare
janniklasrose
enabled auto-merge
November 10, 2026 15:35
janniklasrose
deleted the
janniklasrose/acc/uuid-unique-on-by-default
branch
November 10, 2026 15:58
denik
added a commit
that referenced
this pull request
Nov 10, 2026
Numbered UUIDs from main (#7021); restores the volume_id skip in change-name and the recorded schema_id in user_agent/simple, which the rebase dropped. Co-authored-by: Isaac <no-reply@databricks.com>
tharunbhuk-db
added a commit
that referenced
this pull request
Nov 10, 2026
main now numbers repeated UUIDs in acceptance output (#7021). The pipelines test command stack is based on an older main, so its goldens are regenerated here. This commit becomes empty once that stack is rebased. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
❌ Integration test reportCommit: 688c228
18 interesting tests: 14 flaky, 4 FAIL
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the temporary
UniqueUUIDoption and always distinguish UUIDs, updating acceptance goldens with numeric suffixes.In the materialization-set
batchandremoval_scopetests, register the deployed set ID as[SET1_ID]withread_id.pyand remove the compact-UUID TOML replacements. This makes the dashed local IDs and compact cloud IDs use the same named replacement before request/operation UUIDs are numbered.Why
Expected output should distinguish different UUIDs consistently. #7423 handles the immutable and template comparisons. The materialization-set fix addresses the deterministic cloud mismatch found during the five sequential CI repetitions.
Tests
./task fmt,./task checks,./task lint, and the materialization-set acceptance tests passed. The full local suite was blocked by the unrelated completion-test SIGPIPE and temporary-home cleanup;inittimepassed on retry. Cloud CI validation is pending.This PR was written by Isaac and revised with Codex.