Skip to content

fix(test): make build-id HEAD test run without checkout .git #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danshapiro merged 1 commit into from
Aug 29, 2026
Merged

fix(test): make build-id HEAD test run without checkout .git #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions test/server/build-id.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,25 @@ describe('server build id', () => {
})

it('computeBuildId returns the current git HEAD sha for the repository', () => {
const expected = execFileSync('git', ['rev-parse', 'HEAD'], { cwd: REPO_ROOT })
.toString()
.trim()
expect(computeBuildId(REPO_ROOT)).toBe(expected)
// Build a fixture repo instead of probing this checkout: CI cloud images
// ship the source tree without .git/ (see .gcloudignore/.dockerignore),
// so asserting against REPO_ROOT's HEAD is impossible there. Only a git
// binary is required anywhere this suite runs.
const dir = fs.mkdtempSync(path.join(os.tmpdir(), 'build-id-fixture-repo-'))
try {
execFileSync('git', ['init', '-q', '-b', 'main'], { cwd: dir })
execFileSync(
'git',
['-c', 'user.email=test@example.com', '-c', 'user.name=Test', 'commit', '-q', '--allow-empty', '-m', 'init'],
{ cwd: dir },
)
const expected = execFileSync('git', ['rev-parse', 'HEAD'], { cwd: dir })
.toString()
.trim()
expect(computeBuildId(dir)).toBe(expected)
} finally {
fs.rmSync(dir, { recursive: true, force: true })
}
})

it('computeBuildId falls back to "unknown" outside a git repository', () => {
Expand Down
Loading