fix(test): make build-id HEAD test run without checkout .git - #698
Merged
Conversation
The computeBuildId test asserted against this checkout's HEAD, which is impossible on the cloud vitest/backend images: .git/ is excluded from the build context (.gcloudignore/.dockerignore), so 'git rev-parse HEAD' fails there deterministically. Build a fixture git repo in a tmpdir instead — same coverage, works everywhere a git binary exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/server/build-id.test.ts'scomputeBuildIdtest asserted against the checkout's own HEAD viagit rev-parse HEAD. On cloud vitest images.git/is excluded from the build context (.gcloudignore/".dockerignore"), so the test failed there deterministically — the only red in the full cloud suite at6c541bec.computeBuildId(dir)against that repo's HEAD. Same coverage, works anywhere a git binary exists.Verification
npm run test:vitest -- run test/server/build-id.test.ts --config config/vitest/vitest.server.config.ts→ 8/8 pass.e49c2f66f): all shards green, includingtest/server/build-id.test.ts ✓ (8 tests)on cloud.