Add ROS-style struct frontend - #4
Merged
Merged
Conversation
Add an optional value-like ROS API while preserving Phaser native layout and protobuf wire compatibility, including fixed arrays, oneof variants, and ROS1 intrinsic types.
Generate one-way conversion from protobuf or native Phaser payloads, with deterministic format inference and byte-level compatibility coverage.
Include the shared suppression file in newly added ROS test runfiles so CI can launch them under Valgrind.
Decode ROS1 data into native payloads with deterministic oneof handling and bulk primitive I/O. Reject malformed packed fixed-width protobuf fields.
Move runtime metadata into payload storage, return lightweight field views, and transcode ROS wire data directly to avoid heap work on receive paths.
Explain both generated APIs and show direct protobuf, ROS, and native wire conversion workflows.
Rebind cached nested views before use and keep union field-number spans backed by static storage so sanitizer builds do not access stale payload or stack memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time,Duration, andHeadercompatibilityTest plan
bazel test //... -- -//phaser:perf_testbazel test //phaser:ros_intrinsics_test --strip=never -c dbg --copt=-fsanitize=undefined --copt=-fno-omit-frame-pointer --linkopt=-fsanitize=undefined