[pashagolub]

Closes #1571

Summary

PgBouncer and Pgpool SHOW commands cannot alias columns, so the reaper does it for them.

 DbConnReaper.CollectAndDispatch
   pgx.CollectRows
+  normalizePoolerMeasurements      # pgbouncer / pgpool sources only
+    label column  -> tag_<col> text  (database, user, node_id, hostname, role, status, ...)
+    other column  -> float64          ('true'/'false' -> 1/0, Numeric, numeric text)
+    NULL / unconvertible -> dropped   (debug log)
   dispatchMetricData

 notSupportedMetrics  # pkg/sinks/prometheus.go
   change_events
-  pgbouncer_stats
   pgbouncer_clients   # per-connection cardinality
   pgpool_processes    # per-process cardinality
-  pgpool_stats

• metrics.yaml: avg_* of pgbouncer_stats and lb_weight, replication_delay of pgpool_stats declared as gauges.
• grafana/postgres/v13 pooler dashboards read labels as COALESCE(tag_data->>'x', data->>'x'), so rows written before and after the upgrade both render; last_status_change column removed (text, now dropped).

Evidence

• Before: /metrics has no pgwatch_pgbouncer_stats_* / pgwatch_pgpool_stats_* samples; with the exclusion removed, values are skipped as unsupported datatype: {102 0 false finite true}.
  After:

  normalize(pgbouncer, {database: "pgbouncer", total_query_count: Numeric(1234)})
    == {tag_database: "pgbouncer", total_query_count: 1234.0}
  normalize(pgpool, {status: "up", load_balance_node: "true", last_status_change: "2026-..."})
    == {tag_status: "up", load_balance_node: 1.0}
  AddCacheEntry(pgbouncer_stats, pgpool_stats) cached; pgbouncer_clients, pgpool_processes not
  

  go test ./pkg/reaper/ ./pkg/sinks/ ./pkg/metrics/ passes. Not yet verified against live PgBouncer/Pgpool.

Merge Danger

Door: two-way

Pooler labels now arrive as tag_* source columns, so new Postgres-sink rows keep them in tag_data. v13 dashboards read both layouts, so neither upgrade nor revert breaks them.

Blast Radius: pooler

Only pgbouncer / pgpool sources. v12 dashboards are not updated and show no labels for new rows. Pgpool non-numeric text columns (last_status_change, replication_state, ...) are no longer stored; load_balance_node shows 1/0 instead of true/false.

[coveralls]

Coverage Report for CI Build 38902039285

Warning

No base build found for commit 7725207 on v7.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 89.629%

Details

• Patch coverage: 5 uncovered changes across 1 file (49 of 54 lines covered, 90.74%).

Uncovered Changes

File	Changed	Covered	%
pkg/reaper/pooler.go	53	48	90.57%
Total (2 files)	54	49	90.74%

Coverage Regressions

Requires a base build to compare against. How to fix this →

---

Coverage Stats

Relevant Lines:	5660
Covered Lines:	5073
Line Coverage:	89.63%
Coverage Strength:	0.9 hits per line

---

💛 - Coveralls