Skip to content

[*] silence errcheck on shutdown wait in parseStream - #1606

Merged
pashagolub merged 1 commit into
v7from
fix/errcheck-logparser-stream
Oct 16, 2026
Merged

pashagolub merged 1 commit into
v7from
fix/errcheck-logparser-stream

Conversation

@pashagolub

Copy link
Copy Markdown
Collaborator

Summary

 case <-lp.ctx.Done():
-	<-parsed // the deferred Close races consume if it is still reading
+	<-parsed //nolint:errcheck // the deferred Close races consume if it is still reading
 	return nil

_ = <-parsed is not an option: staticcheck S1005 rejects it.

Evidence

  • Before: CI with golangci-lint latest = v2.15.0: pkg/reaper/logparser_stream.go:38:4: Error return value is not checked (errcheck) (v2.14.0 passed).
    After: golangci-lint v2.15.0 run ./... -> 0 issues.

Merge Danger

Door: two-way

Blast Radius: none

Lint annotation only, no behaviour change. Unblocks "Build and Lint" on open v7 PRs (e.g. #1605).

golangci-lint v2.15.0 reports the discarded `<-parsed` receive. The error
is intentionally ignored on context cancellation.
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 38900592379

Warning

No base build found for commit c5dc3df on v7.
Coverage changes can't be calculated without a base build.
If a base build is processing, this comment will update automatically when it completes.

Coverage: 89.672%

Details

  • Patch coverage: 1 of 1 lines across 1 file are fully covered (100%).

Uncovered Changes

No uncovered changes found.

Coverage Regressions

Requires a base build to compare against. How to fix this →


Coverage Stats

Coverage Status
Relevant Lines: 5606
Covered Lines: 5027
Line Coverage: 89.67%
Coverage Strength: 0.9 hits per line

💛 - Coveralls

@pashagolub pashagolub self-assigned this Oct 16, 2026
@pashagolub pashagolub added the CI Continuous Integration issues label Oct 16, 2026
@pashagolub
pashagolub merged commit 7725207 into v7 Oct 16, 2026
6 checks passed
@pashagolub
pashagolub deleted the fix/errcheck-logparser-stream branch October 16, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants