Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .fullsend/customized/harness/review.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,11 @@ readonly_repo: true
env:
runner:
REVIEW_FINDING_SEVERITY_THRESHOLD: "high"
# Upstream recommends keeping these identical: the review agent reads the sandbox value,
# and the post-script reads the runner value.
REVIEW_PROTECTED_PATHS: |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] config-override

Setting REVIEW_PROTECTED_PATHS in the harness customization overrides the upstream base harness value rather than appending to it. The base harness (referenced via the base: field) sets REVIEW_PROTECTED_PATHS to a comprehensive comma-separated list of governance paths (.claude/, .github/, AGENTS.md, scripts/, CODEOWNERS, etc.). This customization replaces that entire list with only rpms.lock.yaml, removing protected-path enforcement for all previously protected governance and infrastructure paths. This follows from the established override pattern in this file — REVIEW_FINDING_SEVERITY_THRESHOLD similarly overrides the upstream default.

Suggested fix: Include the full upstream protected paths list with rpms.lock.yaml appended. Set the value to the comma-separated list from the upstream harness plus rpms.lock.yaml.

rpms.lock.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would replace all the inherited protected paths.
Could we add the protected paths from upstream as well?

sandbox:
REVIEW_FINDING_SEVERITY_THRESHOLD: "high"
REVIEW_PROTECTED_PATHS: |
rpms.lock.yaml
Loading