Repository navigation
Add rpms.lock.yaml to the protected paths used by the review agent #3745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Acepresso
wants to merge
1
commit into
conforma:main
Choose a base branch
from
Acepresso:ec-2358-protect-rpms-lock
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,5 +23,11 @@ readonly_repo: true | |
| env: | ||
| runner: | ||
| REVIEW_FINDING_SEVERITY_THRESHOLD: "high" | ||
| # Upstream recommends keeping these identical: the review agent reads the sandbox value, | ||
| # and the post-script reads the runner value. | ||
| REVIEW_PROTECTED_PATHS: | | ||
| rpms.lock.yaml | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this would replace all the inherited protected paths. |
||
| sandbox: | ||
| REVIEW_FINDING_SEVERITY_THRESHOLD: "high" | ||
| REVIEW_PROTECTED_PATHS: | | ||
| rpms.lock.yaml | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[high] config-override
Setting REVIEW_PROTECTED_PATHS in the harness customization overrides the upstream base harness value rather than appending to it. The base harness (referenced via the base: field) sets REVIEW_PROTECTED_PATHS to a comprehensive comma-separated list of governance paths (.claude/, .github/, AGENTS.md, scripts/, CODEOWNERS, etc.). This customization replaces that entire list with only rpms.lock.yaml, removing protected-path enforcement for all previously protected governance and infrastructure paths. This follows from the established override pattern in this file — REVIEW_FINDING_SEVERITY_THRESHOLD similarly overrides the upstream default.
Suggested fix: Include the full upstream protected paths list with rpms.lock.yaml appended. Set the value to the comma-separated list from the upstream harness plus rpms.lock.yaml.