Skip to content

Add rpms.lock.yaml to the protected paths used by the review agent - #3745

Open
Acepresso wants to merge 1 commit into
conforma:mainfrom
Acepresso:ec-2358-protect-rpms-lock
Open

Acepresso wants to merge 1 commit into
conforma:mainfrom
Acepresso:ec-2358-protect-rpms-lock

Conversation

@Acepresso

Copy link
Copy Markdown
Contributor

This triggers enhanced review scrutiny when rpms.lock.yaml is modified, making the review agent more likely to examine structural changes (like header removal) beyond simple version bumps.

Ref: https://redhat.atlassian.net/browse/EC-2358
Assisted-by: gpt-6-sol

This triggers enhanced review scrutiny when rpms.lock.yaml is modified,
making the review agent more likely to examine structural changes (like
header removal) beyond simple version bumps.

Ref: https://redhat.atlassian.net/browse/EC-2358
Assisted-by: gpt-6-sol
@Acepresso
Acepresso requested a review from a team as a code owner November 19, 2026 13:06
@coderabbitai

coderabbitai Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review.

Walkthrough

The harness configuration sets REVIEW_PROTECTED_PATHS to rpms.lock.yaml in both the runner and sandbox environments. A comment describes which component reads each setting. Existing high severity thresholds remain unchanged.

Changes: Protected review paths

Layer / File(s) Summary
Set protected paths in both environments
.fullsend/customized/harness/review.yaml
The runner and sandbox environments set REVIEW_PROTECTED_PATHS to rpms.lock.yaml. A comment states that the review agent reads the sandbox setting and the post-script reads the runner setting. The high severity thresholds remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: st3penta, bohdanmar

Merge Risk: Minimal · up to cebe6

This change marks the RPM lockfile as a protected path for review, so structural edits such as header removal get closer scrutiny. No concrete defect was found, and merging is low risk.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title states the main change: rpms.lock.yaml is added to the protected paths used by the review agent. The raw summary confirms REVIEW_PROTECTED_PATHS is set to rpms.lock.yaml in both the runner a…
Description check Passed The description explains the purpose: rpms.lock.yaml changes trigger enhanced review scrutiny, so the agent examines structural changes such as header removal, not only version bumps. It includes a Ji…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title states the main change: rpms.lock.yaml is added to the protected paths used by the review agent. The raw summary confirms REVIEW_PROTECTED_PATHS is set to rpms.lock.yaml in both the runner and sandbox environments of review.yaml. The title is specific and concise.

Full details: Description check

Explanation

The description explains the purpose: rpms.lock.yaml changes trigger enhanced review scrutiny, so the agent examines structural changes such as header removal, not only version bumps. It includes a Jira reference (EC-2358). It does not use the 'What', 'Why', and 'Tickets' headings from the template. The Why content is present, but the What content is brief and implicit, and the template headings are missing.

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 6034c987-bae5-4b84-897d-b9ae7a8f516d
Commits

Reviewing files that changed from the base of the PR and between d688683 and cebe67e.

Files selected for processing: 1

  • .fullsend/customized/harness/review.yaml

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

# Upstream recommends keeping these identical: the review agent reads the sandbox value,
# and the post-script reads the runner value.
REVIEW_PROTECTED_PATHS: |
rpms.lock.yaml

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would replace all the inherited protected paths.
Could we add the protected paths from upstream as well?

@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
acceptance 54.61% <ø> (ø)
generative 12.22% <ø> (ø)
integration 23.62% <ø> (ø)
unit 72.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fullsend-ai-review fullsend-ai-review Bot added the risk/low PR risk: low label Nov 19, 2026
@fullsend-ai-review

Copy link
Copy Markdown

<!-- fullsend:risk-assessment -->
Risk Assessment: low (1/5)

Details

Single-file, 6-line config-only YAML change with no security, CI, or dependency signals and negligible churn history; the only mild concern is 42-day file age, which is insufficient to elevate risk above low.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

High

  • [config-override] .fullsend/customized/harness/review.yaml:28 — Setting REVIEW_PROTECTED_PATHS in the harness customization overrides the upstream base harness value rather than appending to it. The base harness (referenced via the base: field) sets REVIEW_PROTECTED_PATHS to a comprehensive comma-separated list of governance paths (.claude/, .github/, AGENTS.md, scripts/, CODEOWNERS, etc.). This customization replaces that entire list with only rpms.lock.yaml, removing protected-path enforcement for all previously protected governance and infrastructure paths. This follows from the established override pattern in this file — REVIEW_FINDING_SEVERITY_THRESHOLD similarly overrides the upstream default.
    Remediation: Include the full upstream protected paths list with rpms.lock.yaml appended. Set the value to the comma-separated list from the upstream harness plus rpms.lock.yaml, e.g.: .claude/,.cursor/,.pi/,.gitattributes,.gitignore,.github/,.pre-commit-config.yaml,AGENTS.md,agents/,api-servers/,CLAUDE.md,CODEOWNERS,Containerfile,Dockerfile,harness/,images/,plugins/,policies/,profiles/,providers/,scripts/,skills/,rpms.lock.yaml

Labels: PR modifies review agent harness configuration (agentic infrastructure config change).


Next steps:

  • /fs-fix — agent addresses review findings automatically
  • /fs-fix <your instruction> — agent fixes with your specific guidance
  • Push commits directly — review re-runs automatically on push
  • /fs-fix-stop — disable automatic fix runs for this PR

@fullsend-ai-review fullsend-ai-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review comment for full details.

REVIEW_FINDING_SEVERITY_THRESHOLD: "high"
# Upstream recommends keeping these identical: the review agent reads the sandbox value,
# and the post-script reads the runner value.
REVIEW_PROTECTED_PATHS: |

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[high] config-override

Setting REVIEW_PROTECTED_PATHS in the harness customization overrides the upstream base harness value rather than appending to it. The base harness (referenced via the base: field) sets REVIEW_PROTECTED_PATHS to a comprehensive comma-separated list of governance paths (.claude/, .github/, AGENTS.md, scripts/, CODEOWNERS, etc.). This customization replaces that entire list with only rpms.lock.yaml, removing protected-path enforcement for all previously protected governance and infrastructure paths. This follows from the established override pattern in this file — REVIEW_FINDING_SEVERITY_THRESHOLD similarly overrides the upstream default.

Suggested fix: Include the full upstream protected paths list with rpms.lock.yaml appended. Set the value to the comma-separated list from the upstream harness plus rpms.lock.yaml.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants