Repository navigation
Conversation
This triggers enhanced review scrutiny when rpms.lock.yaml is modified, making the review agent more likely to examine structural changes (like header removal) beyond simple version bumps. Ref: https://redhat.atlassian.net/browse/EC-2358 Assisted-by: gpt-6-sol
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
| # Upstream recommends keeping these identical: the review agent reads the sandbox value, | ||
| # and the post-script reads the runner value. | ||
| REVIEW_PROTECTED_PATHS: | | ||
| rpms.lock.yaml |
There was a problem hiding this comment.
I think this would replace all the inherited protected paths.
Could we add the protected paths from upstream as well?
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
<!-- fullsend:risk-assessment --> DetailsSingle-file, 6-line config-only YAML change with no security, CI, or dependency signals and negligible churn history; the only mild concern is 42-day file age, which is insufficient to elevate risk above low. |
ReviewFindingsHigh
Labels: PR modifies review agent harness configuration (agentic infrastructure config change). Next steps:
|
| REVIEW_FINDING_SEVERITY_THRESHOLD: "high" | ||
| # Upstream recommends keeping these identical: the review agent reads the sandbox value, | ||
| # and the post-script reads the runner value. | ||
| REVIEW_PROTECTED_PATHS: | |
There was a problem hiding this comment.
[high] config-override
Setting REVIEW_PROTECTED_PATHS in the harness customization overrides the upstream base harness value rather than appending to it. The base harness (referenced via the base: field) sets REVIEW_PROTECTED_PATHS to a comprehensive comma-separated list of governance paths (.claude/, .github/, AGENTS.md, scripts/, CODEOWNERS, etc.). This customization replaces that entire list with only rpms.lock.yaml, removing protected-path enforcement for all previously protected governance and infrastructure paths. This follows from the established override pattern in this file — REVIEW_FINDING_SEVERITY_THRESHOLD similarly overrides the upstream default.
Suggested fix: Include the full upstream protected paths list with rpms.lock.yaml appended. Set the value to the comma-separated list from the upstream harness plus rpms.lock.yaml.
This triggers enhanced review scrutiny when rpms.lock.yaml is modified, making the review agent more likely to examine structural changes (like header removal) beyond simple version bumps.
Ref: https://redhat.atlassian.net/browse/EC-2358
Assisted-by: gpt-6-sol