Repository navigation
build: link stdc++exp through a generator expression - #7
Merged
Merged
Conversation
The if() was evaluated when building the package, so a package built with gcc made every consumer link stdc++exp, msvc included. The generator expression is exported and evaluated by the consumer.
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
if()aroundtarget_link_libraries(cth INTERFACE stdc++exp)was evaluated when the package was built. A package built with gcc exportedINTERFACE_LINK_LIBRARIES "stdc++exp", so msvc consumers of the same package would try to linkstdc++exp.lib.Now the condition is a generator expression, exported as is and evaluated by the consumer, like
/Zc:preprocessoralready was. Needed to ship one finished package (e.g. inletter_boxed_solver/lib/cth) for every platform.