Repository navigation
build: an option per component, cth links boost-pfr - #16
Merged
Merged
Conversation
CTH_BUILD_OS, CTH_BUILD_CORO, CTH_BUILD_NET (default ON) and CTH_BUILD_WIN (default WIN32) through cth_add_subdirectory, a parent project turns components off before add_subdirectory(cth). The components assert the components they need, cth_win that it targets windows. Bumps lib/cth_cmake for cth_add_subdirectory.
cth/hash/hash_aggregates.hpp includes boost/pfr.hpp, the cth target and the package did not declare the dependency. Consumers had to find boost_pfr themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cth_add_subdirectory(cth_cmake#7):CTH_BUILD_OS,CTH_BUILD_CORO,CTH_BUILD_NET(default ON) andCTH_BUILD_WIN(defaultWIN32). A parent project turns components off withset(CTH_BUILD_<COMPONENT> OFF)beforeadd_subdirectory(cth); the package only contains the built components.cthtarget links boost-pfr.cth/hash/hash_aggregates.hppincludesboost/pfr.hpp, but neither the target nor the package declared it, consumers had to findboost_pfrthemselves.netcomponent.For cth_engine, which adds cth from a submodule with coro, net and win off.
Test plan
CTH_BUILD_NET=OFF CTH_BUILD_CORO=OFF: 192/192, installed package only has cth and osCTH_BUILD_OS=OFFwith coro on fails the configure with the assertadd_subdirectory(lib/cth): 273/273 on gcc and clang, no install on build