Repository navigation
Build the frontend on Node 26 and update dependencies - #53
Merged
Merged
Conversation
- Frontend image on node:26.13.0-alpine (from 24.22.1). - Angular 22.2.5 / CLI 22.2.6 and the remaining frontend dependencies to their current releases, including jsdom 31, stylelint 18 and stylelint-config-standard 41. - stylelint 18's new selector-no-invalid rejects ::ng-deep and has no option to accept it, so it is switched off. - jsdom 31 answers `none` for an uncomputed grid-template-columns; the shortlist treats it like the empty string, as "no grid". - Backend: jsoup 1.24.1, Spotless 8.11.0. openai-java 4.101.0 still fails the chat-stop tests, so the 4.65.0 hold stays.
A root .nvmrc names Node 26; actions/setup-node reads it in both workflows, so the frontend half of check no longer runs on whatever Node the runner ships.
NodePinTest compares the major in .nvmrc with the node:<tag> build stage in frontend/Dockerfile, and checks that both workflows set up Node from .nvmrc. Same shape as BunPinTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
node:26.13.0-alpine(from 24.22.1). The Angular CLI accepts>=26.0.0.noneinstead of''for agrid-template-columnsnothing computed.ShortlistPage.readSplit()read that as one track and hid the second column in the specs; it now treatsnonelike the empty string, as "no grid". A browser can answernonetoo.selector-no-invalidflags all 109::ng-deepselectors and has no option to accept them, so it is switched off. The rule did not exist in 17, so the check covers what it covered.Deliberately not in this PR
>=6.0 <6.1.gradle:9.9.0-jdk25is not published yet, and wrapper and backend image move together.ChatStreamTest,ChatConversationTest,ChatTurnDeadlineTest); the hold at 4.65.0 stays, the comment now names 4.101.0.Verified
./gradlew check --no-configuration-cache --rerun-tasks: green, 1289 backend test cases, 0 failures; frontend lint + unit + browser suites green.bun run build: initial bundle 883 kB, under the 1 MB error budget.docker build -f frontend/Dockerfile .on Node 26: builds.