Repository navigation
Treat a cancelled transition as ended in the browser specs - #54
Merged
Merged
Conversation
transitions() in chat-drawer.browser.spec.ts and shortlist.browser.spec.ts awaited every finite animation's `finished`. A transition cancelled on the way (its element removed, or its value switched back) rejects that promise, and Chromium rejects it with "AbortError: The user aborted a request." -- the error the ISC-461 keyboard-shortcut test failed with about one run in fifteen, on main as well. A cancelled animation has ended, so the rejection is now taken as the end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
transitions()inchat-drawer.browser.spec.tsandshortlist.browser.spec.tswaits for every finite animation'sfinished. A transition cancelled on the way — its element removed, or its value switched back — rejects that promise, and Chromium rejects it withAbortError: The user aborted a request.That is the error
the chat drawer (ISC-432) > the keyboard shortcut (ISC-461) > … at 390pxfailed with in CI on #53, and it is not new: onmainthe spec failed 2 of 30 local runs and once more in a further 15, all with that message. A cancelled animation has ended, so the rejection is now taken as the end rather than as a failure.Test code only; nothing in the app changes.
Evidence
el.animate(…), thencancel()) rejectsfinishedwith exactlyAbortError: The user aborted a request.chat-drawer.browser.spec.tsfailed, onmainand on Build the frontend on Node 26 and update dependencies #53 alike.bun run check:staticgreen.Not in this PR
A second, rarer flake in the same file:
a change of screen (ISC-444) > stays open with ?chat unchanged across every hop at 1440failed once in 68 runs withTimeoutError: locator.click: Timeout 14106ms exceeded.— a different cause, not chased here.