fix(release): if-no-files-found typo (warning → warn)#190
Merged
Conversation
actions/upload-artifact@v4 accepts 'warn', not 'warning'. The typo failed the macOS + Windows artifact-upload steps in the v0.3.3 release run, skipping the manifest job (no latest.json). Build/installers themselves succeeded.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-cli · BYOK · MIT |
This was referenced Jul 21, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivial typo broke the v0.3.3 release:
actions/upload-artifact@v4acceptswarn, notwarning. The artifact-upload step failed on macOS + Windows (ubuntu skipped it — empty updater_key), so the manifest job never ran → nolatest.json. The tauri build + installer upload themselves succeeded. One-character-class fix.