Conversation
#192) * fix(updater): sig glob target*/release → target/**/bundle (cross-compile path) The previous upload-step glob `src-tauri/target*/release/bundle/...` didn't match the macOS cross-compile path `target/<triple>/release/bundle/...` — `*` doesn't cross directory separators, so no `.sig` was uploaded, the manifest job got empty artifacts, and `latest.json` shipped with `platforms: {}` → updater error 'None of the fallback platforms were found'. Switch to `target/**/bundle/...` (`**` crosses dirs) so both the cross- compile path (macOS aarch64/x86_64) and the plain path (windows nsis) match. Also: build-updater-manifest.ts now exits non-zero if no platforms were assembled, so an empty manifest fails the workflow loudly instead of silently shipping a broken one. * fix(updater): recursive .sig find (robust to nested artifact paths) actions/upload-artifact@v4 may preserve directory structure inside the artifact, so the .sig can land nested (not at the updater-<key>/ root). findSig() now walks recursively so the manifest job finds it regardless. Pairs with the glob fix (target/**/bundle) in the prior commit.
Hotfix release — fixes the auto-update manifest so v0.3.3's broken release (empty `platforms` in latest.json → "None of the fallback platforms were found") is superseded by a working one. App code unchanged from v0.3.3. - bump version 0.3.3 → 0.3.4 (package.json, Cargo.toml, Cargo.lock, tauri.conf.json) - CHANGELOG entry Verified: cargo fmt/clippy(-D warnings)/test (18).
🔍 Cora AI Code ReviewReview powered by cora-cli · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync develop → main for v0.3.4 release.
Hotfix: fixes the broken auto-update manifest from v0.3.3 (empty platforms). App code unchanged from v0.3.3; this release ships a working latest.json via the fixed pipeline (#190, #192).