Skip to content

refactor(app): define response-stage protocol - #3147

Draft
james-elicx wants to merge 2 commits into
codex/cdn-v2-pages-request-stagefrom
codex/cdn-v2-app-stage-contracts
Draft

refactor(app): define response-stage protocol#3147
james-elicx wants to merge 2 commits into
codex/cdn-v2-pages-request-stagefrom
codex/cdn-v2-app-stage-contracts

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 2, 2026

Copy link
Copy Markdown
Member

Part 7 of 16 in the staged CDN adapter stack. Depends on #3146.

Summary

  • defines the App Router response-stage protocol and serializable element wire format
  • keeps App-specific request props and validation out of the generic stage contracts
  • covers protocol serialization, malformed input, and stage dispatch behavior

Validation

  • focused App element-wire and worker-stage tests
  • cumulative exact-tip changed-test sweep: 3,461 passed, 2 skipped
  • full exact-tip vp check

Review size

  • Implementation: +330 / -76 LOC
  • Tests and fixtures: +83 / -0 LOC
  • Other (docs, config, lockfile): +0 / -0 LOC
  • 5 changed files

Measured against codex/cdn-v2-pages-request-stage after rebasing onto main@a6931c0.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3147
npm i https://pkg.pr.new/create-vinext-app@3147
npm i https://pkg.pr.new/@vinext/types@3147
npm i https://pkg.pr.new/vinext@3147

commit: 14d0de0

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 14d0de0 against base 2548828 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 0 regressed · 6 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ -0.0%
Client entry size (gzip) vinext 129.6 KB 129.6 KB ⚫ -0.0%
Dev server cold start vinext 3.06 s 3.04 s ⚫ -0.8%
Production build time vinext 3.32 s 3.32 s ⚫ -0.1%
RSC entry closure size (gzip) vinext 119.8 KB 119.8 KB ⚫ -0.0%
Server bundle size (gzip) vinext 203.5 KB 203.4 KB ⚫ -0.0%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 2e2a91c to 8028b16 Compare September 2, 2026 09:43
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 8028b16 to bc68c51 Compare September 2, 2026 09:49
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch 2 times, most recently from ffa6c9e to 8f47f18 Compare September 2, 2026 13:41
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch 2 times, most recently from b063efb to ffb2073 Compare September 2, 2026 15:11
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from ffb2073 to 8251ee5 Compare September 2, 2026 15:21
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
static-export preview production
web preview production

@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch 2 times, most recently from cdd1379 to 9f8230e Compare September 2, 2026 15:41
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 9f8230e to 3ef2fd4 Compare September 2, 2026 16:26
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 3ef2fd4 to a6e2df9 Compare September 2, 2026 16:32
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from a6e2df9 to 3071c23 Compare September 2, 2026 16:36
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 3071c23 to 230ff51 Compare September 2, 2026 16:46
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from 230ff51 to c666e72 Compare September 2, 2026 17:12
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-stage-contracts branch from c666e72 to 14d0de0 Compare September 2, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant