Skip to content

refactor(app): extract response-stage renderer - #3148

Draft
james-elicx wants to merge 8 commits into
codex/cdn-v2-app-stage-contractsfrom
codex/cdn-v2-app-response-stage
Draft

refactor(app): extract response-stage renderer#3148
james-elicx wants to merge 8 commits into
codex/cdn-v2-app-stage-contractsfrom
codex/cdn-v2-app-response-stage

Conversation

@james-elicx

@james-elicx james-elicx commented Sep 2, 2026

Copy link
Copy Markdown
Member

Part 8 of 16 in the staged CDN adapter stack. Depends on #3147.

Summary

  • extracts App page and route-handler rendering into the App response stage
  • preserves RSC and HTML streaming, middleware context, headers, redirects, not-found handling, and response finalization
  • keeps route-handler runtime loading lazy and generated entries focused on wiring

Validation

  • focused App route-handler and RSC-handler tests
  • cumulative exact-tip changed-test sweep: 3,461 passed, 2 skipped
  • full exact-tip vp check

Review size

  • Implementation: +1174 / -103 LOC
  • Tests and fixtures: +1542 / -126 LOC
  • Other (docs, config, lockfile): +4 / -0 LOC
  • 15 changed files

Measured against codex/cdn-v2-app-stage-contracts after rebasing onto main@a6931c0.

@pkg-pr-new

pkg-pr-new Bot commented Sep 2, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@vinext/cloudflare@3148
npm i https://pkg.pr.new/create-vinext-app@3148
npm i https://pkg.pr.new/@vinext/types@3148
npm i https://pkg.pr.new/vinext@3148

commit: 29da06e

@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from dc73986 to 48e8121 Compare September 2, 2026 09:43
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 48e8121 to 99aabf9 Compare September 2, 2026 09:49
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 99aabf9 to 6b5d1ef Compare September 2, 2026 12:47
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 6b5d1ef to 8f7fb2d Compare September 2, 2026 13:41
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 8f7fb2d to a4ce271 Compare September 2, 2026 14:16
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from a4ce271 to b8e66e4 Compare September 2, 2026 15:11
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from b8e66e4 to 566b61e Compare September 2, 2026 15:21
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Performance benchmarks

Compared 29da06e against base 14d0de0 using alternating same-runner rounds. Next.js was unchanged and skipped.

0 improved · 2 regressed · 4 within ±1.5%

Scenario Framework Baseline Current Change
Client bundle size (gzip) vinext 142.3 KB 142.3 KB ⚫ +0.0%
Client entry size (gzip) vinext 129.6 KB 129.6 KB ⚫ +0.0%
Dev server cold start vinext 3.11 s 3.09 s ⚫ -0.8%
Production build time vinext 3.40 s 3.42 s ⚫ +0.7%
RSC entry closure size (gzip) vinext 119.8 KB 125.3 KB 🔴 +4.6%
Server bundle size (gzip) vinext 203.4 KB 216.1 KB 🔴 +6.2%

View detailed results and traces

🟢 improvement · 🔴 regression · ⚫ change below 1.5% · paired base/head

@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from f814825 to 377a8e8 Compare September 2, 2026 15:36
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 377a8e8 to 5b1e149 Compare September 2, 2026 15:41
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 5b1e149 to 52f1ccb Compare September 2, 2026 16:26
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor
Example Preview Production Original
app-router-cloudflare preview production
pages-router-cloudflare preview production
app-router-playground preview production original
realworld-api-rest preview production
nextra-docs-template preview production
benchmarks preview production
hackernews preview production original
workers-cache preview production
static-export preview production
web preview production

@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 52f1ccb to 8a12075 Compare September 2, 2026 16:32
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 8a12075 to 25db278 Compare September 2, 2026 16:37
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 25db278 to 33b7047 Compare September 2, 2026 16:46
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 33b7047 to 186dc76 Compare September 2, 2026 17:12
@james-elicx
james-elicx force-pushed the codex/cdn-v2-app-response-stage branch from 186dc76 to 29da06e Compare September 2, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant