Skip to content

fix(version): avoid reading parent repository metadata #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m-mdy-m merged 1 commit into from
Nov 5, 2026
Merged

fix(version): avoid reading parent repository metadata #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions lua/cdin/runtime/core/version.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,27 @@ local function git_command(arguments)
end

local function from_git()
local root = repository_root()
if not root then
return nil
end

local redirect = command_error_redirect()
local git_top = read_command(git_command("rev-parse --show-toplevel") .. redirect)
if not git_top then
return nil
end

-- Installed Runtime modules may live inside another Git checkout (for
-- example, CDIN's share/cdin/lua tree). Git walks upward from -C and would
-- otherwise report the host application's version as the Runtime version.
-- An empty --show-prefix means root is the top-level of the Git repository;
-- a non-empty prefix means this is only a nested installation directory.
local git_prefix = read_command(git_command("rev-parse --show-prefix") .. redirect)
if git_prefix ~= nil then
return nil
end

local describe = read_command(
git_command('describe --tags --long --dirty --match "v[0-9]*"') .. redirect
)
Expand Down
Loading