Repository navigation
fix(version): avoid reading parent repository metadata - #1
Merged
Merged
Conversation
m-mdy-m
marked this pull request as ready for review
November 5, 2026 09:27
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Runtime version resolution when Runtime Lua modules are installed inside another Git checkout.
version.luapreviously rangit describefrom the installed module directory. Git walks upward, so when CDIN installed Runtime undershare/cdin/lua, it found CDIN's.gitdirectory and reported CDIN's version as the Runtime version. The Runtime release metadata module was therefore bypassed.The resolver now uses Git metadata only when the Runtime module root is the top-level of that Git worktree. A nested installation falls back to the packaged
release_metadata.luaversion, preserving the component's own release identity.Verification
runtime started version=1.0.0-rc.1 host_api=1.0.0 kernel_abi=1.1.0at https://github.com/cdin-editor/cdin/actions/runs/42001264611.The PR remains Draft and is not authorized for merge.