[RBSALSIS-697]: ALS NG CAP Java Plugin - Audit Logging for Support User Impersonation - #131
Conversation
… in the common section of the event.
…ser functionality from userInfo.
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR introduces v2 audit event format support with SAP support user impersonation context. The code is generally well-structured, but there are a few correctness issues: formatEventTypeToV2 can throw StringIndexOutOfBoundsException on short/empty event types, createGeneralEventDataNode can have framework-set fields silently overwritten by caller-supplied event data, and the test schema cache uses a non-thread-safe HashMap. The unnecessary two-line variable split in AuditLogNGCommunicator is also flagged for clarity.
PR Bot Information
Version: 1.29.2
- LLM:
anthropic--claude-4.6-sonnet - Experiment Variant:
control - Event Trigger:
issue_comment.created - File Content Strategy: Full file content
- Correlation ID:
f05052e0-89c3-11f1-9c72-3a6f8b5c94ed
…required version.
There was a problem hiding this comment.
The PR introduces v2 audit logging with support-user impersonation, v2 CloudEvents envelope format, and a restructured JSON payload. The code is generally well-structured, but please address the previously raised issues — particularly the setAll field-overwrite bug in createGeneralEventDataNode, the StringIndexOutOfBoundsException in formatEventTypeToV2 for short strings, the silent "null" tenant fallback, and the HashMap thread-safety concern in the test schema cache.
PR Bot Information
Version: 1.29.18
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
issue_comment.created - Correlation ID:
04058e30-9519-11f1-9f52-441fea971bca - File Content Strategy: Full file content
StefanHenke
left a comment
StefanHenke
left a comment
There was a problem hiding this comment.
lgtm for AdminAs from a CAP perspective
3 participants
No description provided.