fix(fips): swap bcprov-jdk18on for bc-fips to enable FIPS 140-3 compliance - #132
Open
andwehrm wants to merge 1 commit into
Open
fix(fips): swap bcprov-jdk18on for bc-fips to enable FIPS 140-3 compliance#132andwehrm wants to merge 1 commit into
andwehrm wants to merge 1 commit into
Conversation
…iance Replace org.bouncycastle:bcprov-jdk18on + bcpkix-jdk18on (non-FIPS) with the FIPS 140-3 validated distribution: bc-fips:2.1.3, bcpkix-fips:2.1.8, bctls-fips:2.1.20, bcutil-fips:2.1.5. CertificateHttpClientConfig: BouncyCastleProvider → BouncyCastleFipsProvider, KeyStore provider "PKCS12" → "PKCS12/BCFIPS", decryptor builder pinned to "BCFIPS" provider. All 20 existing tests pass. Downstream tracking: https://jira.tools.sap/browse/RBSALSRV-511
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The plugin currently pulls
org.bouncycastle:bcpkix-jdk18on(non-FIPS). Consumers targeting FIPS 140-3 / SAP NS2 environments need the FIPS-validatedbc-fipsdistribution instead. Downstream tracking: RBSALSRV-511 (internal).Change
pom.xml: swapbcprov-jdk18on+bcpkix-jdk18onforbc-fips+bcpkix-fips+bctls-fips+bcutil-fips.CertificateHttpClientConfig:BouncyCastleProvider→BouncyCastleFipsProvider.Verification
mvn clean verifypasses locally.Reviewers
@mtsvetanov071 @georgi-shakev @lisajulia — happy to include this in the 0.0.5 release cut following #131 if it fits.