Repository navigation
Adopt Android SDK 7.6.0, iOS SDK 7.1.0 (Gradle plugin 4.1.1) - #38
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
|
Claude finished @krassx's task in 1m 2s —— View job Deep review of PR #38: Adopt Android SDK 7.6.0 / iOS SDK 7.1.0 (Gradle plugin 4.1.1)
I found no functional bugs. I did not run the test suite, the codegen checks or any build, so everything below comes from reading the code. Findings (all P3 Low, documentation or comment drift)
Not verified or still open
Summary
|
| "urlTemplate": "https://download.bugsee.com/sdk/options/{sdk}/{version}.json", | ||
| "fixtureDir": "test/fixtures/option_manifests", | ||
| "provenance": "Both SDKs publish an immutable options-manifest.json per release (bugsee/specs sdk/options, manifestVersion 1), generated from the live option registry: android/7.5.0.json (generatedAt 2026-11-06) and ios/7.0.1.json (generatedAt 2026-11-03), android fetched 2026-11-06, ios 2026-11-03, vendored verbatim as android.json / ios.json in fixtureDir. `dart scripts/sync_option_manifests.dart --check` (weekly, native-pins.yml) refetches and diffs; everything else reads the committed copies offline." | ||
| "provenance": "Both SDKs publish an immutable options-manifest.json per release (bugsee/specs sdk/options, manifestVersion 1), generated from the live option registry: android/7.5.1.json (generatedAt 2026-11-11) and ios/7.0.1.json (generatedAt 2026-11-03), android fetched 2026-11-12, ios 2026-11-03, vendored verbatim as android.json / ios.json in fixtureDir. `dart scripts/sync_option_manifests.dart --check` (weekly, native-pins.yml) refetches and diffs; everything else reads the committed copies offline." |
There was a problem hiding this comment.
P3 Low: stale provenance (docs claim contradicts the vendored fixtures)
Problem: optionsManifest.provenance still says the vendored manifests are android/7.5.1.json (generatedAt 2026-11-11) and ios/7.0.1.json (generatedAt 2026-11-03), fetched 2026-11-12 / 2026-11-03. This PR re-vendored test/fixtures/option_manifests/* at Android 7.6.0 (generatedAt 2026-11-16T21:58:23Z) and iOS 7.1.0 (2026-11-16T19:43:51Z), which is what option_registry.g.dart now records. The feedback.provenance line (37) has the same problem: it cites bugsee-android-feedback 7.5.1 / Maven Central 2026-11-12, while feedback.androidArtifact is now pinned at 7.6.0 in packages/bugsee_flutter_feedback/android/build.gradle.
Impact: The provenance is the audit trail for these pins, and .claude/CLAUDE.md says a doc claim about code must be checked against the code. A reader checking the manifests against this text, or re-running sync_option_manifests.dart --check, is pointed at the wrong versions and dates. No test catches it, so it is easy to miss.
Fix: Update both strings to android/7.6.0.json (generatedAt 2026-11-16) and ios/7.1.0.json (generatedAt 2026-11-16) with the real fetch date, and state the verified bugsee-android-feedback 7.6.0 publication date. Check that bugsee-android-feedback 7.6.0 actually exists on Maven Central.
| ## Known gaps and filed issues | ||
|
|
||
| State checked with `gh issue view` on 2026-11-06 (the Android pins moved to 7.5.0 / plugin 4.1.0 that day; the closed rows are kept with how each was verified). | ||
| State checked with `gh issue view` on 2026-11-06 (the Android pins moved to 7.5.0 / plugin 4.1.0 that day to 7.5.1 / 4.1.1 on 2026-11-12 and to 7.6.0 / 4.1.1 (iOS 7.1.0) on 2026-11-17; the closed rows are kept with how each was verified). |
There was a problem hiding this comment.
P3 Low: garbled sentence and stale row in the issue table
- This line is now ungrammatical: "(the Android pins moved to 7.5.0 / plugin 4.1.0 that day to 7.5.1 / 4.1.1 on 2026-11-12 and to 7.6.0 ...)". A "; then" or "," is missing, so it reads as if 7.5.0 moved to 7.5.1 "that day". It also says "State checked ... on 2026-11-06", but the pins have moved twice since, and nothing in the table was re-checked after 2026-11-06. Either re-check the rows with
gh issue viewor say that they were not re-checked. - Line 75 (
bugsee-cocoa#265/bugsee-android#299) says "closed, in both pins (iOS 7.0.1, Android 7.5.1)". The pins are now iOS 7.1.0 / Android 7.6.0. The fix is still included, but "in both pins" is no longer literally true of the named versions.
| tool ?? Platform.resolvedExecutable, | ||
| tool != null | ||
| ? [symbols] | ||
| : ['run', 'native_stack_traces:decode', 'translate', '-d', symbols], |
There was a problem hiding this comment.
P3 Low: dart run depends on the working directory, and other docs still point at flutter symbolize
Platform.resolvedExecutable run native_stack_traces:decode ...resolves the package through the pub workspace of the current directory. The script is documented asdart scripts/verify_symbolization.dart ...and is also launched by the device harness (scripts/device/android_scenarios.dart:780). Run from outside the repo root, or from a directory that is not in the workspace,dart runfails with a "could not find package" error. That failure is a nonzero exit with unrelated output, not a symbolization result. ConsiderworkingDirectory: <repo root>(derived fromPlatform.script) onProcess.start. I did not run this script, so this is from reading the code only.doc/exceptions.md:228andscripts/device/android_scenarios.dart:763still say thatflutter symbolize"decodes the same format" and name it as an equivalent offline decoder. The PR's own measurement says it fails on 3.50 symbols, so those two mentions should be aligned with this change.
08c6702 to
71c2659
Compare
|
Claude finished @krassx's task in 29s —— View job Re-review of PR #38 after the push of
|
| // `dart run` resolves the package through the workspace of the working directory: the repository root. | ||
| workingDirectory: tool != null | ||
| ? null | ||
| : File.fromUri(Platform.script).parent.parent.path, |
There was a problem hiding this comment.
P3 Low: the new workingDirectory breaks a relative --symbols path (introduced by 71c2659)
Problem: The build-id check above reads File(symbols) relative to the caller's working directory. The child process now runs in the repo root, and symbols is passed to translate -d unchanged. A relative path resolves against two different directories.
Scenario: From /tmp, run dart /repo/scripts/verify_symbolization.dart --symbols ./app.android-arm64.symbols --entry .... The build-id check passes. The decoder then looks for /repo/app.android-arm64.symbols and fails. Its stderr is drained and discarded (process.stderr.drain), so you only see FAIL: missing from the symbolized stack: [...], with no cause. The documented command (doc/exceptions.md:219) and the harness (file.path, cwd = repo root) are unaffected. Only a relative path from another directory breaks.
Fix: Pass File(symbols).absolute.path to the decoder. Consider printing the child's stderr on failure instead of draining it.
| : File.fromUri(Platform.script).parent.parent.path, | |
| : ['run', 'native_stack_traces:decode', 'translate', '-d', File(symbols).absolute.path], |
71c2659 to
28e46e6
Compare
|
Claude finished @krassx's task in 15s —— View job Re-review of PR #38 after the push of
|
Pins, provenance, vendored option manifests, extracted fixtures, SwiftPM pins, docs. Android 7.6.0 and iOS 7.1.0 turn the shake (and Android's notification-bar) report trigger off by default; the migration guide says so. No wrapper SPI changed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: Ia4a6097ba2c4c70104b8b867c50274fbfeeb58f5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I47587bfdb1aa581bdab97be8b3733629f1118430
Change-Id: Ib72e4d909afd44e796bc20a6ddda630828b676f0
….50's 'flutter symbolize' fails on 3.50 symbols
The offline symbolization check of scenario 4 failed ('Cannot locate isolate instructions section in snapshot') on the symbols of the
same 3.50 build; native_stack_traces 0.7.1 decodes them. The backend's dart_symbolize must handle Dart 3.14 snapshots: not verified.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: Iaca5c01b472677b3a0fe4f57432dfb9bd31fa6bc
…ng directory and the stale flutter-symbolize mentions Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I403462aa09fd6d962e2f5cc6a545bdc92c95e0d6
…ny directory and shows the decoder's error Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I68c84388b1c413186b80b6edc911144cce373ad9
28e46e6 to
7bb89a4
Compare
|
Claude finished @krassx's task in 17s —— View job Re-review of PR #38, no new commits since the last reviewThe branch head is still
Summary
|
Supersedes #31 (7.5.1). Pins, provenance, vendored option manifests, extracted fixtures, SwiftPM pins, docs; the harness follows the floor of native-versions.json and symbolizes with native_stack_traces (Flutter 3.50's
flutter symbolizefails on 3.50 symbols).BugseeCrashExtensionSwiftPM product (iOS 27+), not linked by the wrapper.🤖 Generated with Claude Code
https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8