Skip to content

Adopt Android SDK 7.6.0, iOS SDK 7.1.0 (Gradle plugin 4.1.1) - #38

Merged
krassx merged 6 commits into
nextgenfrom
chore/native-7.6.0-7.1.0
Nov 18, 2026
Merged

krassx merged 6 commits into
nextgenfrom
chore/native-7.6.0-7.1.0

Conversation

@krassx

@krassx krassx commented Nov 17, 2026

Copy link
Copy Markdown
Contributor

Supersedes #31 (7.5.1). Pins, provenance, vendored option manifests, extracted fixtures, SwiftPM pins, docs; the harness follows the floor of native-versions.json and symbolizes with native_stack_traces (Flutter 3.50's flutter symbolize fails on 3.50 symbols).

🤖 Generated with Claude Code

https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Files ignored due to path filters: 3

  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • pubspec.lock is excluded by !**/*.lock
Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 48153a49-a296-403a-8285-e2e87514f6f1
Commits

Reviewing files that changed from the base of the PR and between 28e46e6 and 7bb89a4.

Files ignored due to path filters: 3

  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • pubspec.lock is excluded by !**/*.lock

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • New Features
    • Updated the Android and iOS native SDKs to 7.6.0 and 7.1.0, respectively, with support for Android Gradle plugin 4.1.1.
    • Improved default stack-trace decoding for symbolized Flutter builds.
  • Bug Fixes
    • Shake and Android notification-bar reporting triggers are now off by default. Enable them in your options to retain the previous behavior.
    • Network URL sanitization now applies to HTTP breadcrumbs before filtering or reporting, except for breadcrumbs explicitly added without filtering.

The pull request updates the Android native SDK pin to 7.6.0 and the iOS pin to 7.1.0. It updates the required Android Gradle plugin to 4.1.1 and refreshes option metadata, documentation, fixtures, and tests for the new versions and defaults. The symbolization verification script now uses native_stack_traces by default, resolves the symbols path, and reports captured decoder errors.

Possibly related PRs

Change: Other

Merge Risk: Minimal · previous review 28e46

This PR updates the native SDK pins, the Gradle plugin version, option defaults, documentation, and the symbolization script. No actionable merge-blocking risk was found. The shake and notification-bar defaults now being off is documented in the migration guide.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: adopting Android SDK 7.6.0 and iOS SDK 7.1.0 with Gradle plugin 4.1.1. The raw summary shows the version pins, provenance, fixtures, and docs were updated to these exa…
Description check Passed The description is related to the changeset. It lists the native SDK pins, vendored option manifests, fixtures, SwiftPM pins, and docs. It also covers the behaviour changes (default trigger changes, t…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: adopting Android SDK 7.6.0 and iOS SDK 7.1.0 with Gradle plugin 4.1.1. The raw summary shows the version pins, provenance, fixtures, and docs were updated to these exact versions, so the title matches the changeset.

Full details: Description check

Explanation

The description is related to the changeset. It lists the native SDK pins, vendored option manifests, fixtures, SwiftPM pins, and docs. It also covers the behaviour changes (default trigger changes, the BugseeCrashExtension product) and the symbolization switch to native_stack_traces, which match the raw summary.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c101ac0-7c27-4b9d-8015-1543f4c4fdef
Commits

Reviewing files that changed from the base of the PR and between 4430776 and 28e46e6.

Files ignored due to path filters: 3

  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • pubspec.lock is excluded by !**/*.lock
Files selected for processing: 28

  • .claude/CLAUDE.md
  • CHANGELOG.md
  • PLAN.md
  • README.md
  • doc/README.md
  • doc/architecture.md
  • doc/exceptions.md
  • doc/migration-from-9x.md
  • example/android/settings.gradle.kts
  • ios/bugsee_flutter/Package.swift
  • ios/wrapper_tests/Package.swift
  • lib/src/options/bugsee_options.g.dart
  • lib/src/options/option_registry.g.dart
  • native-versions.json
  • packages/bugsee_flutter_feedback/CHANGELOG.md
  • packages/bugsee_flutter_feedback/android/build.gradle
  • packages/bugsee_flutter_feedback/ios/bugsee_flutter_feedback/Package.swift
  • packages/bugsee_flutter_feedback/ios/feedback_wrapper_tests/Package.swift
  • pubspec.yaml
  • scripts/device/android_scenarios.dart
  • scripts/verify_symbolization.dart
  • test/device_harness_test.dart
  • test/fixtures/data_requests.json
  • test/fixtures/option_manifests/android.json
  • test/fixtures/option_manifests/docs.json
  • test/fixtures/option_manifests/ios.json
  • test/fixtures/report_enums.json
  • test/option_manifests_test.dart

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 1m 2s —— View job


Deep review of PR #38: Adopt Android SDK 7.6.0 / iOS SDK 7.1.0 (Gradle plugin 4.1.1)

  • Read the diff against origin/fix/ci-stable-3.47 (30 files, 5 commits)
  • Cross-checked the pins, the generated option registry, the fixtures, the harness changes and the docs
  • Posted inline findings and this summary

I found no functional bugs. I did not run the test suite, the codegen checks or any build, so everything below comes from reading the code.

Findings (all P3 Low, documentation or comment drift)

  1. native-versions.json:46 (and :37): stale provenance. optionsManifest.provenance still cites android/7.5.1.json and ios/7.0.1.json, but the vendored fixtures and option_registry.g.dart are now 7.6.0 / 7.1.0. feedback.provenance still cites bugsee-android-feedback 7.5.1, while the feedback package is pinned at 7.6.0. No guard catches this text. (inline comment)
  2. PLAN.md:67 and :75. The sentence about the pin moves is now ungrammatical and says the table was checked on 2026-11-06, which is no longer accurate after two pin moves. The #265/#299 row says "in both pins (iOS 7.0.1, Android 7.5.1)", but the pins are 7.1.0 / 7.6.0. (inline comment on :67)
  3. scripts/verify_symbolization.dart:79. dart run native_stack_traces:decode resolves the package from the current directory, so running the script outside the workspace fails with an unrelated error. doc/exceptions.md:228 and scripts/device/android_scenarios.dart:763 still present flutter symbolize as an equivalent decoder, which this PR measured as failing on 3.50 symbols. (inline comment)
  4. test/option_manifests_test.dart:128 (not in the diff, so no inline comment). The comment still says Android 7.5.0: 88 ... iOS 7.0.1: 72, but the fixtures are now 7.6.0 / 7.1.0. Update the comment to name the versions the counts were last confirmed against.

Not verified or still open

  • iOS 7.1.0 device run is not done (stated in the description). ios.sdkBuild = b65bdca06-9 and the XCFramework revisions were read from the binary and the tag, not from a run. The harness guards will fail loudly on the first iOS run if the banner differs. That is the right failure mode, but the PR should not be called device-verified for iOS.
  • The default flips (shake on both platforms, notification bar on Android) are documented in the migration guide and the generated option docs. The wrapper code and tests do not reference either option, so I found nothing that relied on the old defaults.
  • I could not verify the claims about the SDKs themselves (the delayed HTTP response body event, the hardened serializers) from this repo. The wrapper's network capture goes through Dart's HttpOverrides, not the SDK's HttpURLConnection hook, so I expect no effect.

Summary

  1. Overall risk: Low.
  2. Merge recommendation: Approve once the stale text in items 1 to 4 is fixed. None of it blocks the merge, and it can go in a follow-up. Waiting for the iOS device run is a team call.
  3. Most important to fix: the native-versions.json provenance strings (item 1), since that file is the declared single source of truth for the pins. Then the verify_symbolization.dart working-directory dependency (item 3).
  4. Positives:
    • The pin move is applied consistently across Gradle, all four Package.swift files, both Package.resolved files, the fixtures and the generated registry.
    • The harness now reads the Flutter floor from native-versions.json instead of hard-coding it.
    • The lockfile was updated alongside the new dev dependency (--enforce-lockfile friendly).
    • The PR description is honest about what was and was not verified.

Comment thread native-versions.json Outdated
"urlTemplate": "https://download.bugsee.com/sdk/options/{sdk}/{version}.json",
"fixtureDir": "test/fixtures/option_manifests",
"provenance": "Both SDKs publish an immutable options-manifest.json per release (bugsee/specs sdk/options, manifestVersion 1), generated from the live option registry: android/7.5.0.json (generatedAt 2026-11-06) and ios/7.0.1.json (generatedAt 2026-11-03), android fetched 2026-11-06, ios 2026-11-03, vendored verbatim as android.json / ios.json in fixtureDir. `dart scripts/sync_option_manifests.dart --check` (weekly, native-pins.yml) refetches and diffs; everything else reads the committed copies offline."
"provenance": "Both SDKs publish an immutable options-manifest.json per release (bugsee/specs sdk/options, manifestVersion 1), generated from the live option registry: android/7.5.1.json (generatedAt 2026-11-11) and ios/7.0.1.json (generatedAt 2026-11-03), android fetched 2026-11-12, ios 2026-11-03, vendored verbatim as android.json / ios.json in fixtureDir. `dart scripts/sync_option_manifests.dart --check` (weekly, native-pins.yml) refetches and diffs; everything else reads the committed copies offline."

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Low: stale provenance (docs claim contradicts the vendored fixtures)

Problem: optionsManifest.provenance still says the vendored manifests are android/7.5.1.json (generatedAt 2026-11-11) and ios/7.0.1.json (generatedAt 2026-11-03), fetched 2026-11-12 / 2026-11-03. This PR re-vendored test/fixtures/option_manifests/* at Android 7.6.0 (generatedAt 2026-11-16T21:58:23Z) and iOS 7.1.0 (2026-11-16T19:43:51Z), which is what option_registry.g.dart now records. The feedback.provenance line (37) has the same problem: it cites bugsee-android-feedback 7.5.1 / Maven Central 2026-11-12, while feedback.androidArtifact is now pinned at 7.6.0 in packages/bugsee_flutter_feedback/android/build.gradle.

Impact: The provenance is the audit trail for these pins, and .claude/CLAUDE.md says a doc claim about code must be checked against the code. A reader checking the manifests against this text, or re-running sync_option_manifests.dart --check, is pointed at the wrong versions and dates. No test catches it, so it is easy to miss.

Fix: Update both strings to android/7.6.0.json (generatedAt 2026-11-16) and ios/7.1.0.json (generatedAt 2026-11-16) with the real fetch date, and state the verified bugsee-android-feedback 7.6.0 publication date. Check that bugsee-android-feedback 7.6.0 actually exists on Maven Central.

Comment thread PLAN.md Outdated
## Known gaps and filed issues

State checked with `gh issue view` on 2026-11-06 (the Android pins moved to 7.5.0 / plugin 4.1.0 that day; the closed rows are kept with how each was verified).
State checked with `gh issue view` on 2026-11-06 (the Android pins moved to 7.5.0 / plugin 4.1.0 that day to 7.5.1 / 4.1.1 on 2026-11-12 and to 7.6.0 / 4.1.1 (iOS 7.1.0) on 2026-11-17; the closed rows are kept with how each was verified).

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Low: garbled sentence and stale row in the issue table

  1. This line is now ungrammatical: "(the Android pins moved to 7.5.0 / plugin 4.1.0 that day to 7.5.1 / 4.1.1 on 2026-11-12 and to 7.6.0 ...)". A "; then" or "," is missing, so it reads as if 7.5.0 moved to 7.5.1 "that day". It also says "State checked ... on 2026-11-06", but the pins have moved twice since, and nothing in the table was re-checked after 2026-11-06. Either re-check the rows with gh issue view or say that they were not re-checked.
  2. Line 75 (bugsee-cocoa#265 / bugsee-android#299) says "closed, in both pins (iOS 7.0.1, Android 7.5.1)". The pins are now iOS 7.1.0 / Android 7.6.0. The fix is still included, but "in both pins" is no longer literally true of the named versions.

tool ?? Platform.resolvedExecutable,
tool != null
? [symbols]
: ['run', 'native_stack_traces:decode', 'translate', '-d', symbols],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Low: dart run depends on the working directory, and other docs still point at flutter symbolize

  1. Platform.resolvedExecutable run native_stack_traces:decode ... resolves the package through the pub workspace of the current directory. The script is documented as dart scripts/verify_symbolization.dart ... and is also launched by the device harness (scripts/device/android_scenarios.dart:780). Run from outside the repo root, or from a directory that is not in the workspace, dart run fails with a "could not find package" error. That failure is a nonzero exit with unrelated output, not a symbolization result. Consider workingDirectory: <repo root> (derived from Platform.script) on Process.start. I did not run this script, so this is from reading the code only.
  2. doc/exceptions.md:228 and scripts/device/android_scenarios.dart:763 still say that flutter symbolize "decodes the same format" and name it as an equivalent offline decoder. The PR's own measurement says it fails on 3.50 symbols, so those two mentions should be aligned with this change.

@krassx
krassx force-pushed the chore/native-7.6.0-7.1.0 branch from 08c6702 to 71c2659 Compare November 17, 2026 10:22
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 29s —— View job


Re-review of PR #38 after the push of 71c2659

I read the new commit against my earlier findings. I did not run the tests, the codegen checks or any build, so this comes from reading the code.

Earlier findings, now fixed:

  1. native-versions.json provenance: optionsManifest.provenance now cites android/7.6.0.json and ios/7.1.0.json. feedback.provenance now cites bugsee-android-feedback 7.6.0. I could not check the Maven Central date of 2026-11-16 from here.
  2. PLAN.md: the pin-move sentence is rewritten. The #265/#299 row now says the fix was measured at the older pins.
  3. doc/exceptions.md and scripts/device/android_scenarios.dart: the flutter symbolize mentions now say it fails on 3.50 symbols.
  4. test/option_manifests_test.dart: the comment now names 7.6.0 / 7.1.0.
  5. scripts/verify_symbolization.dart: dart run now gets a workingDirectory set to the repo root. This introduced the new finding below.

New finding (P3 Low, inline): scripts/verify_symbolization.dart:83. The decoder now runs in the repo root, but a relative --symbols path is still passed to it unchanged. The build-id check reads it from the caller's directory and passes. The decoder then looks for it under the repo root and fails. Because stderr is drained, the only output is FAIL: missing from the symbolized stack, with no cause. The documented command and the device harness are not affected. The fix is to pass File(symbols).absolute.path.

Still open: the iOS 7.1.0 device run is not done, as the PR description says. ios.sdkBuild and the XCFramework revisions come from the binary and the tag, not from a run.

Summary

  1. Overall risk: Low.
  2. Merge recommendation: Approve. The remaining finding is a small script fix and does not block the merge. Waiting for the iOS device run is a team call.
  3. Most important to fix: make the --symbols path absolute in verify_symbolization.dart.
  4. Positives: all four earlier findings were fixed in one commit, and the docs now say which version each measurement was taken at.

// `dart run` resolves the package through the workspace of the working directory: the repository root.
workingDirectory: tool != null
? null
: File.fromUri(Platform.script).parent.parent.path,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3 Low: the new workingDirectory breaks a relative --symbols path (introduced by 71c2659)

Problem: The build-id check above reads File(symbols) relative to the caller's working directory. The child process now runs in the repo root, and symbols is passed to translate -d unchanged. A relative path resolves against two different directories.

Scenario: From /tmp, run dart /repo/scripts/verify_symbolization.dart --symbols ./app.android-arm64.symbols --entry .... The build-id check passes. The decoder then looks for /repo/app.android-arm64.symbols and fails. Its stderr is drained and discarded (process.stderr.drain), so you only see FAIL: missing from the symbolized stack: [...], with no cause. The documented command (doc/exceptions.md:219) and the harness (file.path, cwd = repo root) are unaffected. Only a relative path from another directory breaks.

Fix: Pass File(symbols).absolute.path to the decoder. Consider printing the child's stderr on failure instead of draining it.

Suggested change
: File.fromUri(Platform.script).parent.parent.path,
: ['run', 'native_stack_traces:decode', 'translate', '-d', File(symbols).absolute.path],

@krassx
krassx force-pushed the chore/native-7.6.0-7.1.0 branch from 71c2659 to 28e46e6 Compare November 17, 2026 11:45
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 15s —— View job


Re-review of PR #38 after the push of 28e46e6

I read the new commit against my earlier findings. I did not run the tests, the codegen checks or any build, so this comes from reading the code.

Earlier finding, now fixed:

  • scripts/verify_symbolization.dart relative --symbols path. --symbols is now made absolute with File(symbolsArg).absolute.path before the build-id check and before it is passed to the decoder, so both use the same file whatever the caller's directory is. The null check for a missing --symbols still runs after that, so the usage message and exit code 64 are unchanged. The --tool branch also gets the absolute path, which is harmless. --entry is only read in the caller's directory, so it is not affected. The script now reads the decoder's stderr and prints it after decoder said: on failure, so the failure shows its cause.

New findings: none. The change is small and I found no regression in it.

Still open: the iOS 7.1.0 device run is not done, as the PR description says. ios.sdkBuild and the XCFramework revisions come from the binary and the tag, not from a run.

Summary

  1. Overall risk: Low.
  2. Merge recommendation: Approve from the code side. All my earlier findings are fixed across 71c2659 and 28e46e6. Waiting for the iOS device run is a team call.
  3. Most important to fix: nothing left from the review.
  4. Positives: each review finding was fixed in a small commit with the reason in the message. The symbolizer failure output is now diagnosable.

krassx and others added 6 commits November 17, 2026 17:20
Pins, provenance, vendored option manifests, extracted fixtures, SwiftPM pins, docs. Android 7.6.0 and iOS 7.1.0 turn the shake
(and Android's notification-bar) report trigger off by default; the migration guide says so. No wrapper SPI changed.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: Ia4a6097ba2c4c70104b8b867c50274fbfeeb58f5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I47587bfdb1aa581bdab97be8b3733629f1118430
Change-Id: Ib72e4d909afd44e796bc20a6ddda630828b676f0
….50's 'flutter symbolize' fails on 3.50 symbols

The offline symbolization check of scenario 4 failed ('Cannot locate isolate instructions section in snapshot') on the symbols of the
same 3.50 build; native_stack_traces 0.7.1 decodes them. The backend's dart_symbolize must handle Dart 3.14 snapshots: not verified.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: Iaca5c01b472677b3a0fe4f57432dfb9bd31fa6bc
…ng directory and the stale flutter-symbolize mentions

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I403462aa09fd6d962e2f5cc6a545bdc92c95e0d6
…ny directory and shows the decoder's error

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I68c84388b1c413186b80b6edc911144cce373ad9
@krassx
krassx force-pushed the chore/native-7.6.0-7.1.0 branch from 28e46e6 to 7bb89a4 Compare November 17, 2026 12:20
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 17s —— View job


Re-review of PR #38, no new commits since the last review

The branch head is still 7bb89a4, which my last review covered as 28e46e6. I read scripts/verify_symbolization.dart again against the earlier findings. I did not run the tests, the codegen checks or any build.

  • Earlier findings: all are fixed. I re-read the symbolizer. --symbols is made absolute before the build-id check and before it is passed to the decoder. The decoder's stderr is printed after decoder said: on failure.
  • New findings: none.
  • Still open: the iOS 7.1.0 device run is not done, as the PR description says. ios.sdkBuild and the XCFramework revisions come from the binary and the tag, not from a run.

Summary

  1. Overall risk: Low.
  2. Merge recommendation: Approve from the code side. Waiting for the iOS device run is a team call.
  3. Most important to fix: nothing left from the review.
  4. Positives: each review finding was fixed in a small commit with the reason in the message. The symbolizer failure output is now diagnosable.

@krassx
krassx changed the base branch from fix/ci-stable-3.47 to nextgen November 18, 2026 05:21
@krassx
krassx merged commit e032e80 into nextgen Nov 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant