Repository navigation
Conversation
Ran the backend's dart_symbolize (bugsee-symbolication-aux 06db90f, Dart 2.19.6 and 3.14) on the real stack and symbols of a Flutter 3.50.0 release build: it decodes the stack the worker feeds it (header stripped) and crashes on the same stack with its header, like flutter symbolize 3.50 (native_stack_traces 0.6.1); Dart 3.14 symbols have _kDartSnapshotText, not _kDartIsolateSnapshotInstructions. 0.7.x decodes both. Adds the stack text as a fixture with a test, makes verify_symbolization.dart feed --tool the worker's input, and corrects the docs, PLAN gaps and the harness not-covered entry. iOS: Mach-O symbols file checked with a synthetic stack only. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: Ia2bf5c2674e13979c14785958f96fa9ac028d7cd
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 48 minutes. View limit details
No actionable comments were generated in the recent review. Summary
Change: Other Merge Risk:
|
|
Claude finished @krassx's task in 33s —— View job Review of PR #39 (docs: backend symbolizer against Dart 3.14 stacks)
I did not run Finding (P3 Low): Not verified, and worth saying when merging:
Summary
|
| // With --tool: the worker's input, the stack from the first `#00` on. | ||
| if (tool != null) { | ||
| final m = RegExp(r'^(.*?)(\s*#00.*)', dotAll: true).firstMatch(stack); | ||
| if (m != null) stack = m.group(2)!; |
There was a problem hiding this comment.
P3 Low: --tool input is not exactly what the worker sends
Problem: m.group(2) keeps the leading \s* (a newline plus the 4-space indent of #00) and every frame keeps its indent. The worker port in test/exceptions_worker_contract_test.dart (obfuscatedFrameLines) drops the empty first line and trim()s every frame. The comment above and doc/exceptions.md say this is "the input the worker gives it".
Impact: The check is meant to stand in for the backend's input. If dart_symbolize is sensitive to indentation or a leading blank line, this script can pass or fail where production does the opposite. The table in doc/exceptions.md says the stripped stack "symbolized", but I could not tell whether that run used the trimmed or the untrimmed form.
Fix: Reuse the same rule as the port: split into lines, drop a leading empty line, trim each line, and join with \n. Or soften the wording to "from the first #00" and say the whitespace is not normalised.
verify_symbolization.dart --tool now drops a leading empty line and trims each frame (obfuscatedFrameLines). The earlier stripped-stack runs used the untrimmed text flutter.py passes; re-run with the trimmed form on all three builds (Dart 2.19.6, 3.14, 0.7.1 vendored): same frames. The three places that cited the native_stack_traces 0.7.0 changelog now quote it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: Ie1dd86e4929ee3b1c0e00bef5b594097333b62d6
|
Claude finished @krassx's task in 22s —— View job Re-review of PR #39 after the latest push (
|
Measured what the Bugsee backend's
dart_symbolizedoes with stacks from Dart 3.14 / Flutter 3.50--obfuscate --split-debug-infobuilds, and corrected the repo's claims.bugsee-background-worker:crash/managed/dart.py,symbolfiles/flutter.py) strips everything before the first#00and pipes the frames todart_symbolize(bugsee-symbolication-aux,dart-symbolize/, commit 06db90f, Dart 2.19.6, vendored 2023native_stack_traces).flutter symbolize3.50 (native_stack_traces0.6.1). Cause: Dart 3.14 symbols have_kDartSnapshotTextand no_kDartIsolateSnapshotInstructions.native_stack_traces0.7.x decodes both forms; the backend works today because of the stripping and thevirtaddress.LC_UUID; decoded with a synthetic stack only. A real iOS stack is not verified.verify_symbolization.dart --toolfeed the worker's input, and updatesdoc/exceptions.md,doc/verification.md,PLAN.mdand the harness not-covered entry.No backend change was made; the suggested patch is for its owner.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8