Repository navigation
Floor: Flutter 3.50 / Dart 3.14 (fixes the red stable checks) - #36
Conversation
…rial.dart; one example setup builds on it and on the 3.41 floor Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I4950fb5752e29c158dac321aeb2879112bf82394
|
Important Review skippedToo many files! This PR contains 116 files, which is 16 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.
|
|
Claude finished @krassx's task in 33s —— View job PR review: CI fix for Flutter 3.50 stable (AGP 9, material deprecation)I read the diff against Overall risk: Low. The changes are build config for the example app plus Merge recommendation: Fine to merge once the stale docs below are fixed or tracked. This is a recommendation only, not an approval. Most important issues
Checked, no problem found
Not verified: the iOS jobs on 3.50, as the author notes. Positives
|
| @@ -16,9 +15,6 @@ android { | |||
| targetCompatibility = JavaVersion.VERSION_17 | |||
| } | |||
There was a problem hiding this comment.
Severity: P3 Low
Problem: Removing kotlinOptions left a double blank line here. The comment on line 3 still says the Flutter plugin must follow "the Android and Kotlin Gradle plugins", but no Kotlin plugin is applied any more.
Impact: Cosmetic and a stale comment. Nothing breaks.
Fix: Drop one blank line and reword the comment to "after the Android Gradle plugin".
native-versions.json, pubspecs, CI, native-pins and the docs move together. The example and tests import material_ui (the deprecation workaround and the espresso namespace flag go: the floor now builds on AGP 9). The Dart 3.14 formatter and prefer_initializing_formals changed many files mechanically. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I0f987f43504ea707d80ec184cdd0545d9c23b076
|
Claude finished @krassx's task in 1m 0s —— View job PR review: Floor moves to Flutter 3.50 / Dart 3.14I re-read the diff against Overall risk: Low. Library code changes are formatter churn plus Merge recommendation: Fine to merge after the stale references below are fixed. This is a recommendation only, not an approval. Earlier findings (from the previous review comment)
New findings
Checked, no problem found
Not verified: the iOS jobs on 3.50, and the Most important issues to fix: the stale AGP/Kotlin snippet in Positives
|
| runs-on: ubuntu-latest | ||
| timeout-minutes: 45 | ||
| # 3.41.0 is the first Flutter where a SwiftPM-only plugin resolves on Linux | ||
| # 3.50.0 is the first Flutter where a SwiftPM-only plugin resolves on Linux |
There was a problem hiding this comment.
Severity: P3 Low
Problem: The comment is now false. 3.50.0 is not the first Flutter where a SwiftPM-only plugin resolves on Linux. The measurements cited in the next line and in PLAN.md D5 put that at 3.41.0. The find-and-replace changed the number but not the meaning.
Impact: A reader gets a wrong rationale for the floor. Both matrices now run the same version on the floor and stable legs (lines 92-94 and 148-150 pin 3.50.0 while the other leg is the unpinned stable, also 3.50.0 today). The two legs only differ once stable moves past 3.50. Until then each matrix pays for a duplicate job.
Fix: Reword the comment, for example "3.50.0 is the floor (native-versions.json flutter.min); 3.41.0 was the first where a SwiftPM-only plugin resolves on Linux". Optionally say in CI.md that the stable leg is redundant until Flutter 3.51.
…options excludes Flutter 3.50 writes on pub get Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I98f888d520624246661105413baa59d1de11b134
|
Claude finished @krassx's task in 23s —— View job PR review (re-run on push
|
…sions.json, not a hard-coded 3.41.0 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: Ic1dd487a3f06d041766c83724fd77a2618efb54d
…ionales, floor comments README shows AGP 9 and no kotlin-android; the JDK 25 claim is replaced by what was measured (debug APK built on Gradle 9.3.1); the meta and stack_trace comments say what 3.50.0 requires (meta ^1.19.0, stack_trace ^1.12.2); the CI floor comment, CI.md and PLAN D5 no longer call 3.50.0 the SwiftPM minimum. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I8f7d5449ac752c3f0e93036880cf6e7c444e9268
|
Claude finished @krassx's task in 44s —— View job PR review (re-run on pushes
|
| @@ -10,7 +10,7 @@ import 'package:bugsee_flutter/src/secure/secure_region.dart'; | |||
| // `cacheExtent` is deprecated on stable, but the floor (3.41.0) has no | |||
| // `scrollCacheExtent` yet. | |||
| // ignore_for_file: deprecated_member_use | |||
There was a problem hiding this comment.
Severity: P3 Low
Problem: The comment says the floor (3.41.0) has no scrollCacheExtent, so the file-wide ignore_for_file: deprecated_member_use is needed. The floor is 3.50.0 now, so the premise is stale. The blanket ignore also hides any other deprecation in this 600+ line file.
Fix: Check whether 3.50.0 has scrollCacheExtent. If it does, migrate the three cacheExtent uses (lines ~367, 554, 641) and drop the ignore. If not, reword the comment to 3.50.0 and narrow the ignore to those lines.
… now that the floor has it Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I35475e9e12839a39d5f6ae381e710bd7bbac8df0
|
Claude finished @krassx's task in 19s —— View job PR review (re-run on push
|
…onstraint Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8 Change-Id: I8e6ac9602d3d28ce67ce0eb6d1010c39da2da0a8
|
Claude finished @krassx's task in 13s —— View job PR review (re-run on push
|
Moves the floor to Flutter 3.50.0 / Dart 3.14.0 for the 10.0 major (user decision), which also fixes the red
stablechecks on #31–#35 (stable is 3.50.0).material_uireplacespackage:flutter/material.dart(dart fix --code=migrate_design_widgets), so no deprecation ignores.prefer_initializing_formals: mechanical churn in ~70 files (formatting is pinned to the floor).🤖 Generated with Claude Code
https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8