Skip to content

Floor: Flutter 3.50 / Dart 3.14 (fixes the red stable checks) - #36

Merged
krassx merged 7 commits into
nextgenfrom
fix/ci-stable-3.47
Nov 18, 2026
Merged

krassx merged 7 commits into
nextgenfrom
fix/ci-stable-3.47

Conversation

@krassx

@krassx krassx commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Moves the floor to Flutter 3.50.0 / Dart 3.14.0 for the 10.0 major (user decision), which also fixes the red stable checks on #31–#35 (stable is 3.50.0).

  • Example on Gradle 9.3.1 + AGP 9.1.1 (Flutter 3.50 requires AGP 9); builds on 3.50.0 without the espresso namespace workaround.
  • material_ui replaces package:flutter/material.dart (dart fix --code=migrate_design_widgets), so no deprecation ignores.
  • Dart 3.14 formatter + prefer_initializing_formals: mechanical churn in ~70 files (formatting is pinned to the floor).
  • native-versions.json, pubspecs, ci.yml, native-pins.yml, lock file, README/CHANGELOG/PLAN D5/CLAUDE.md/CI.md updated together.
  • Verified locally on 3.50.0: analyze (root, feedback), flutter test (1384), bridge/option codegen checks, Android unit tests, apk debug build, iOS debug build (no codesign).
  • Not done here: Direct Interop adoption (separate evaluation).

🤖 Generated with Claude Code

https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8

…rial.dart; one example setup builds on it and on the 3.41 floor

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I4950fb5752e29c158dac321aeb2879112bf82394
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Too many files!

This PR contains 116 files, which is 16 over the limit of 100.

To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

Check out review usage here.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d0f5c811-1c7c-4164-8034-b65fa94cc397
Commits

Reviewing files that changed from the base of the PR and between 51c695f and 709bb0f.

Files ignored due to path filters: 3

  • packages/bugsee_flutter_feedback/pigeons/pubspec.lock is excluded by !**/*.lock
  • pigeons/pubspec.lock is excluded by !**/*.lock
  • pubspec.lock is excluded by !**/*.lock
Files selected for processing: 116

  • .claude/CLAUDE.md
  • .github/CI.md
  • .github/workflows/ci.yml
  • .github/workflows/native-pins.yml
  • CHANGELOG.md
  • PLAN.md
  • README.md
  • analysis_options.yaml
  • doc/migration-from-9x.md
  • doc/verification.md
  • example/README.md
  • example/analysis_options.yaml
  • example/android/app/build.gradle.kts
  • example/android/gradle.properties
  • example/integration_test/attachments_test.dart
  • example/integration_test/facade_test.dart
  • example/integration_test/feedback_test.dart
  • example/integration_test/view_hierarchy_test.dart
  • example/ios/Flutter/AppFrameworkInfo.plist
  • example/ios/Runner.xcodeproj/project.pbxproj
  • example/lib/attachments_screen.dart
  • example/lib/exceptions_screen.dart
  • example/lib/facade_screen.dart
  • example/lib/feedback_screen.dart
  • example/lib/logs_screen.dart
  • example/lib/main.dart
  • example/lib/network_screen.dart
  • example/lib/verify_main.dart
  • example/lib/view_hierarchy_screen.dart
  • example/pubspec.yaml
  • lib/src/exceptions/error_capture.dart
  • lib/src/logs/log_capture.dart
  • lib/src/logs/log_event.dart
  • lib/src/network/network_event.dart
  • lib/src/network/network_service.dart
  • lib/src/network/url_redaction.dart
  • lib/src/report/attachments.dart
  • lib/src/report/created_report.dart
  • lib/src/report/report_proxy.dart
  • lib/src/secure/secure_region.dart
  • lib/src/view_hierarchy/publisher.dart
  • native-versions.json
  • packages/bugsee_flutter_feedback/CHANGELOG.md
  • packages/bugsee_flutter_feedback/README.md
  • packages/bugsee_flutter_feedback/analysis_options.yaml
  • packages/bugsee_flutter_feedback/example/example.md
  • packages/bugsee_flutter_feedback/pigeons/bridge.dart
  • packages/bugsee_flutter_feedback/pigeons/pubspec.yaml
  • packages/bugsee_flutter_feedback/pubspec.yaml
  • packages/bugsee_flutter_feedback/test/feedback_test.dart
  • pigeons/bridge.dart
  • pigeons/pubspec.yaml
  • pubspec.yaml
  • scripts/check_native_pins.dart
  • scripts/device/android_device.dart
  • scripts/device/android_harness.dart
  • scripts/device/android_scenarios.dart
  • scripts/device/build.dart
  • scripts/device/checks.dart
  • scripts/device/core/log_parsers.dart
  • scripts/device/ios_scenarios.dart
  • scripts/device/mock.dart
  • scripts/device/report.dart
  • scripts/device/toolchain.dart
  • scripts/extract_data_requests.dart
  • scripts/extract_report_enums.dart
  • scripts/generate_options.dart
  • scripts/generate_pigeon.dart
  • scripts/publish_feedback.sh
  • scripts/sync_option_manifests.dart
  • scripts/verify_option_manifests.dart
  • test/body_capture_test.dart
  • test/bugsee_facade_test.dart
  • test/created_report_test.dart
  • test/device_harness_test.dart
  • test/endpoint_test.dart
  • test/error_capture_test.dart
  • test/exception_payload_test.dart
  • test/exceptions_drift_test.dart
  • test/exceptions_facade_test.dart
  • test/exceptions_worker_contract_test.dart
  • test/facade_drift_test.dart
  • test/facade_test.dart
  • test/feedback_package_drift_test.dart
  • test/helpers/option_samples.dart
  • test/http_capture_fake_test.dart
  • test/http_capture_test.dart
  • test/launch_drift_test.dart
  • test/launch_options_test.dart
  • test/lifecycle_drift_test.dart
  • test/log_capture_test.dart
  • test/log_pipeline_test.dart
  • test/logs_drift_test.dart
  • test/logs_facade_test.dart
  • test/native_versions_test.dart
  • test/network_drift_test.dart
  • test/network_facade_test.dart
  • test/network_pipeline_test.dart
  • test/network_service_test.dart
  • test/option_manifests_test.dart
  • test/options_registry_test.dart
  • test/public_api_test.dart
  • test/report_attachments_drift_test.dart
  • test/report_enum_parity_test.dart
  • test/report_handlers_drift_test.dart
  • test/report_handlers_test.dart
  • test/secure_rects_drift_test.dart
  • test/secure_region_test.dart
  • test/secure_view_test.dart
  • test/url_redaction_test.dart
  • test/view_hierarchy_drift_test.dart
  • test/view_hierarchy_privacy_test.dart
  • test/view_hierarchy_publisher_test.dart
  • test/view_hierarchy_test.dart
  • test/wrapper_identity_test.dart
  • test/wrapper_registration_test.dart

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

No actionable comments were generated in the recent review.

Summary

Summary by CodeRabbit

  • Documentation
    • Clarified the example Android build’s Gradle and Android plugin versions, configuration options, and Flutter compatibility guidance.
  • Chores
    • Updated the example Android build tooling to newer Gradle and Android plugin versions, with configuration adjustments to support the updated setup.
    • Kept the example and tests compatible with the project’s supported Flutter version.

The example Android build now uses Gradle 9.3.1 and Android Gradle Plugin 9.1.1. The configuration removes explicit Kotlin plugin declarations and the Kotlin JVM target, and adds three Android Gradle properties. The CI documentation describes this setup and its compatibility notes. Example screens and tests add analyzer suppressions for deprecated member use; no test behavior changes are reported.

Change: Other

Merge Risk: Minimal · previous review 51c69

This change updates the example app's Android build setup and silences analyzer deprecation notices. It does not alter the library's runtime behavior, and no actionable merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title names the main change, the move of the project floor to Flutter 3.50.0 / Dart 3.14, which the description and objectives both state. It also names the stated purpose, fixing the red stable c…
Description check Passed The description states the purpose of the change. It moves the floor to Flutter 3.50.0 / Dart 3.14.0 and fixes the red stable checks. It explains the Gradle 9.3.1 and AGP 9.1.1 changes, the material_u…
Full details: Title check

Explanation

The title names the main change, the move of the project floor to Flutter 3.50.0 / Dart 3.14, which the description and objectives both state. It also names the stated purpose, fixing the red stable checks. The changeset matches this scope: Gradle and AGP upgrades, version pins across native-versions.json, pubspecs and CI, and deprecation ignores that support the 3.50 move.

Full details: Description check

Explanation

The description states the purpose of the change. It moves the floor to Flutter 3.50.0 / Dart 3.14.0 and fixes the red stable checks. It explains the Gradle 9.3.1 and AGP 9.1.1 changes, the material_ui migration with no deprecation ignores, the formatter churn, and the files updated. These details match the raw summary, which lists Gradle, AGP, Kotlin plugin, and deprecation-ignore edits. The description therefore relates directly to the changeset.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 06bd78d4-5ea4-4ea5-a48e-79d5aba410be
Commits

Reviewing files that changed from the base of the PR and between b415a38 and 51c695f.

Files selected for processing: 21

  • .github/CI.md
  • example/android/app/build.gradle.kts
  • example/android/gradle.properties
  • example/android/gradle/wrapper/gradle-wrapper.properties
  • example/android/settings.gradle.kts
  • example/integration_test/attachments_test.dart
  • example/integration_test/facade_test.dart
  • example/integration_test/view_hierarchy_test.dart
  • example/lib/attachments_screen.dart
  • example/lib/exceptions_screen.dart
  • example/lib/facade_screen.dart
  • example/lib/feedback_screen.dart
  • example/lib/logs_screen.dart
  • example/lib/main.dart
  • example/lib/network_screen.dart
  • example/lib/verify_main.dart
  • example/lib/view_hierarchy_screen.dart
  • test/secure_view_test.dart
  • test/view_hierarchy_privacy_test.dart
  • test/view_hierarchy_publisher_test.dart
  • test/view_hierarchy_test.dart
Files with no reviewable changes: 1

  • example/android/app/build.gradle.kts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@claude

claude Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 33s —— View job


PR review: CI fix for Flutter 3.50 stable (AGP 9, material deprecation)

I read the diff against nextgen and checked the surrounding docs and guards. I did not run any builds or tests. The PR description says the author ran them.

Overall risk: Low. The changes are build config for the example app plus ignore comments in the example and tests. No library or runtime code changes.

Merge recommendation: Fine to merge once the stale docs below are fixed or tracked. This is a recommendation only, not an approval.

Most important issues

  1. P2, README.md:58: The user-facing Android setup still shows AGP 8.11.1, Kotlin 2.2.20, kotlin-android and "Gradle 8.14". That is the setup this PR shows to be broken on Flutter 3.50. The "Docs" rule in CLAUDE.md requires the docs to change with the behaviour.
    • The JDK 17/21 rationale is also stale: Gradle 9.3.1 replaces the "Gradle 8.14 cannot parse JDK 25" claim. It appears in native-versions.json, scripts/device/toolchain.dart:36 and .github/CI.md:129. Re-measure it rather than assume it still holds.
  2. P3, example/android/app/build.gradle.kts:16: A leftover double blank line, and a comment that still mentions the Kotlin Gradle plugin.

Checked, no problem found

  • No drift test pins the example's AGP, Gradle or Kotlin versions. The only AGP literals found by grep are the library modules' classpath(...:8.11.1), which test/feedback_package_drift_test.dart:317 guards, and this PR doesn't touch them. The author reports the example building with them on 3.41.0 and 3.50.0.
  • The ignore: deprecated_member_use comments are consistent. They are scoped to the import line, with the reason stated.
  • The uniquePackageNames=false rationale is documented in CI.md.

Not verified: the iOS jobs on 3.50, as the author notes.

Positives

  • One example setup serves both the floor and stable, instead of per-channel forks.
  • Every opt-out is explained in CI.md, with the condition for dropping it.
    · branch fix/ci-stable-3.47

@@ -16,9 +15,6 @@ android {
targetCompatibility = JavaVersion.VERSION_17
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: P3 Low
Problem: Removing kotlinOptions left a double blank line here. The comment on line 3 still says the Flutter plugin must follow "the Android and Kotlin Gradle plugins", but no Kotlin plugin is applied any more.
Impact: Cosmetic and a stale comment. Nothing breaks.
Fix: Drop one blank line and reword the comment to "after the Android Gradle plugin".

native-versions.json, pubspecs, CI, native-pins and the docs move together. The example and tests import material_ui (the
deprecation workaround and the espresso namespace flag go: the floor now builds on AGP 9). The Dart 3.14 formatter and
prefer_initializing_formals changed many files mechanically.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I0f987f43504ea707d80ec184cdd0545d9c23b076
@krassx krassx changed the title CI: fix the stable channel (Flutter 3.50): AGP 9, material deprecation Floor: Flutter 3.50 / Dart 3.14 (fixes the red stable checks) Nov 12, 2026
@claude

claude Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 1m 0s —— View job


PR review: Floor moves to Flutter 3.50 / Dart 3.14

I re-read the diff against origin/nextgen (both commits) and checked the surrounding docs, guards and scripts. I did not run builds or tests. The PR description says the author ran them on 3.50.0. I did not push anything or change any files.

Overall risk: Low. Library code changes are formatter churn plus prefer_initializing_formals. The real changes are the version floor, the example's Gradle/AGP setup and the material_ui imports. I found no runtime bug. The floor change was only partly propagated, so some docs and one script are stale.

Merge recommendation: Fine to merge after the stale references below are fixed. This is a recommendation only, not an approval.

Earlier findings (from the previous review comment)

  • Still open: README.md:57-68 still tells users to use AGP 8.11.1, org.jetbrains.kotlin.android and id("kotlin-android"), which this PR removes from the example. The JDK 17/21 "Gradle 8.14" rationale is also still in README.md:20, .github/CI.md:129, native-versions.json:19 and scripts/device/toolchain.dart:36.
  • Still open: the double blank line and the "Kotlin Gradle plugins" comment in example/android/app/build.gradle.kts (see the earlier inline comment).

New findings

  1. P2, scripts/device/toolchain.dart:29: The device harness still prefers $HOME/fvm/versions/3.41.0/bin/flutter when it exists. The pubspecs now require >=3.50.0.

    • Impact: The harness is not in CI. On a machine with the old fvm install, verify.dart picks 3.41.0 over the flutter on PATH, and pub get or the build fails on the SDK constraint. The device evidence for the release (PLAN.md step 4) comes from this harness.
    • Fix: Use 3.50.0, or read it from native-versions.json flutter.min. scripts/device/core/log_parsers.dart:56-57 has 3.41.0/3.11.0 examples that may need the same update.
    • I could not attach this as an inline comment because the line is not in the diff.
  2. P3, .github/workflows/ci.yml:141: The comment now says 3.50.0 is "the first Flutter where a SwiftPM-only plugin resolves on Linux". That is false: PLAN.md D5 and the measurements point to 3.41.0.

    • A related effect: the floor and stable legs of both matrices are the same Flutter version (3.50.0) until stable moves past it. Each matrix runs a duplicate job until then.
    • Fix: Reword the comment, and say in CI.md that the stable leg is redundant until Flutter 3.51.
  3. P3, .github/CI.md:113: It still says to run flutter pub get "on the floor Flutter (3.41.0)" when changing a dependency. The floor is 3.50.0. A maintainer following it on 3.41.0 cannot resolve.

    • PLAN.md D5's last column still says "the floor is a consequence of D2, not a choice". That is no longer true.
    • doc/verification.md:61,137 still records 3.41.0 as "the pinned floor". The evidence is historical, but the "pinned floor" label is wrong now.
  4. P3, packages/bugsee_flutter_feedback/example/example.md:11: The published example still imports package:flutter/material.dart, which is deprecated since 3.47. The PR migrates every other place. Users on the new floor who copy it get a deprecation warning.

  5. P3, pubspec.yaml comments: The comments "the floor Flutter (3.50.0) ships 1.17.0" (meta) and "Flutter 3.50.0 pins 1.12.1 for flutter_test" (stack_trace) were only renumbered from 3.41.0, not re-measured. The lock file now resolves meta 1.19.0.

    • The same assumption sits in native-versions.json:41 and CI.md ("Pigeon needs a newer meta than Flutter 3.50.0 ships"). The CLAUDE.md "Docs" rule says a doc claim about code is checked against the code.
    • If 3.50 ships meta >= 1.18, the separate pigeons/ package may no longer be needed, so this is worth checking.

Checked, no problem found

  • test/native_versions_test.dart compares the floor in the workflows, pubspecs and native-pins.yml Dart SDK (3.14.0). All of those were updated together.
  • lib/ has no flutter/material.dart imports. material_ui is a dev dependency of the root and a dependency of the example only, so the published package does not pick it up.
  • The example's Gradle 9.3.1 / AGP 9.1.1 setup and the migrator-written builtInKotlin/newDsl opt-outs are explained in CI.md. The library modules still use AGP 8.11.1 in buildscript (guarded by test/feedback_package_drift_test.dart). The author reports the example builds with them.

Not verified: the iOS jobs on 3.50, and the project.pbxproj and AppFrameworkInfo.plist edits (they look like Flutter migrator output).

Most important issues to fix: the stale AGP/Kotlin snippet in README.md (earlier finding), the 3.41.0 fvm path in the device harness, and the false floor comment and stale 3.41.0 references in CI.md and PLAN.md.

Positives

  • The floor is moved in one commit across the JSON, pubspecs, workflows, lock file and docs, and the existing drift guards catch partial edits.
  • The formatter churn is mechanical and confined to the floor's formatter.
  • The opt-outs in the example are documented with their reasons.
    · branch fix/ci-stable-3.47

Comment thread .github/workflows/ci.yml Outdated
runs-on: ubuntu-latest
timeout-minutes: 45
# 3.41.0 is the first Flutter where a SwiftPM-only plugin resolves on Linux
# 3.50.0 is the first Flutter where a SwiftPM-only plugin resolves on Linux

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: P3 Low
Problem: The comment is now false. 3.50.0 is not the first Flutter where a SwiftPM-only plugin resolves on Linux. The measurements cited in the next line and in PLAN.md D5 put that at 3.41.0. The find-and-replace changed the number but not the meaning.
Impact: A reader gets a wrong rationale for the floor. Both matrices now run the same version on the floor and stable legs (lines 92-94 and 148-150 pin 3.50.0 while the other leg is the unpinned stable, also 3.50.0 today). The two legs only differ once stable moves past 3.50. Until then each matrix pays for a duplicate job.
Fix: Reword the comment, for example "3.50.0 is the floor (native-versions.json flutter.min); 3.41.0 was the first where a SwiftPM-only plugin resolves on Linux". Optionally say in CI.md that the stable leg is redundant until Flutter 3.51.

…options excludes Flutter 3.50 writes on pub get

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I98f888d520624246661105413baa59d1de11b134
@claude

claude Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 23s —— View job


PR review (re-run on push fa75af9): Floor moves to Flutter 3.50 / Dart 3.14

This push adds one commit, fa75af9. It formats packages/bugsee_flutter_feedback/pigeons/bridge.dart and adds build/**, android/** and ios/** to the analyzer.exclude list in the three analysis_options.yaml files (root, example, feedback package). I read the diff and re-checked the earlier findings against the current tree. I did not run builds or tests. I did not push or change any files.

New findings: none.

  • The analyzer excludes only skip native directories and build output. lib/, test/, scripts/ and pigeons/ are still analyzed. The Pigeon Dart outputs live under lib/, so they are not excluded.
  • The bridge formatting is mechanical.

Earlier findings: none are fixed by this push. All of them are still present in the tree:

  • P2, README.md:57-68: still shows AGP 8.11.1, org.jetbrains.kotlin.android and id("kotlin-android"). The "Gradle 8.14" JDK rationale is also still in README.md:20, .github/CI.md:129, native-versions.json:19 and scripts/device/toolchain.dart:36.
  • P2, scripts/device/toolchain.dart:29: the harness still prefers $HOME/fvm/versions/3.41.0/bin/flutter, which can no longer satisfy the >=3.50.0 pubspecs. scripts/device/core/log_parsers.dart:56-57 still has 3.41.0/3.11.0 examples.
  • P3, .github/workflows/ci.yml:141: the comment says 3.50.0 is the first Flutter where a SwiftPM-only plugin resolves on Linux. PLAN.md D5 measures that at 3.41.0.
    • The floor and stable legs are the same Flutter version (3.50.0) until stable moves past it.
  • P3, .github/CI.md:113: still says to run flutter pub get on "the floor Flutter (3.41.0)".
    • The last column of PLAN.md D5 still says "the floor is a consequence of D2, not a choice".
    • doc/verification.md:61 still labels 3.41.0 "the pinned floor".
  • P3, packages/bugsee_flutter_feedback/example/example.md:11: still imports package:flutter/material.dart.
  • P3, example/android/app/build.gradle.kts:3,16: the stale Kotlin plugin comment and the double blank line.
  • P3, pubspec.yaml: the meta and stack_trace comments were renumbered, not re-measured. The lock file resolves meta 1.19.0.

Overall risk: Low. No runtime bug found. The remaining items are stale docs, comments and one harness script.

Merge recommendation: Fine to merge once the stale references are fixed or tracked. This is a recommendation only, not an approval.

Most important issues to fix:

  1. The stale AGP/Kotlin snippet in README.md.
  2. The 3.41.0 fvm path in scripts/device/toolchain.dart.
  3. The false floor comment in ci.yml and the stale 3.41.0 references in CI.md, PLAN.md and doc/verification.md.

Positives

  • The floor change is propagated across the JSON, pubspecs, workflows and lock file, and the existing drift guards enforce that.
  • The analyzer excludes keep Flutter 3.50's pub get rewrites from showing up as churn.
    · branch fix/ci-stable-3.47

krassx and others added 2 commits November 17, 2026 15:19
…sions.json, not a hard-coded 3.41.0

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: Ic1dd487a3f06d041766c83724fd77a2618efb54d
…ionales, floor comments

README shows AGP 9 and no kotlin-android; the JDK 25 claim is replaced by what was measured (debug APK built on Gradle 9.3.1); the
meta and stack_trace comments say what 3.50.0 requires (meta ^1.19.0, stack_trace ^1.12.2); the CI floor comment, CI.md and PLAN D5
no longer call 3.50.0 the SwiftPM minimum.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I8f7d5449ac752c3f0e93036880cf6e7c444e9268
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 44s —— View job


PR review (re-run on pushes cbf7afc, 6427d43): Floor moves to Flutter 3.50 / Dart 3.14

I read both new commits and re-checked every earlier finding against the current tree. I did not run builds or tests, and I pushed nothing.

Earlier findings: all fixed

  • README AGP/Kotlin snippet: now AGP 9.1.1 and no kotlin-android. The JDK 25 rationale was replaced in README.md, .github/CI.md, native-versions.json and the harness comment.
  • Device harness fvm path: scripts/device/toolchain.dart now reads flutter.min from native-versions.json, and the log_parsers.dart examples were updated. It imports dart:convert and the key exists.
  • ci.yml floor comment, CI.md and PLAN D5: reworded and correct. D5 now says the 3.50.0 floor is a choice and 3.41.0 is the SwiftPM minimum.
  • example.md: now imports material_ui.
  • example/android/app/build.gradle.kts: the double blank line and the Kotlin comment are gone.
  • meta and stack_trace comments: now state what 3.50.0 requires. The Pigeon-in-its-own-package rationale is marked as no longer holding, and moving it is deliberately left out of this PR.

New findings (both P3)

  1. pigeons/pubspec.lock:253 and packages/bugsee_flutter_feedback/pigeons/pubspec.lock: both locks still say dart: ">=3.11.0 <4.0.0", but both pubspec.yaml files now say sdk: ^3.14.0. The root lock was regenerated (>=3.14.0).
    • Impact: The next pub get in those directories rewrites the lock. scripts/generate_pigeon.dart runs pub get --enforce-lockfile. I did not test whether pub treats a stale sdks: entry as a lock change. If it does, --check fails in CI. If not, the rewrite shows up as churn in an unrelated PR.
    • Fix: Run dart pub get in both pigeons/ directories and commit the locks. This is not an inline comment because the files are not in the diff.
  2. test/secure_region_test.dart:12 (inline comment): the comment says the floor (3.41.0) has no scrollCacheExtent, and the file-wide ignore_for_file: deprecated_member_use hangs on that. The floor is 3.50.0 now. Check whether 3.50.0 has scrollCacheExtent. If it does, migrate and drop the ignore. If not, fix the comment and narrow the ignore.

Minor, not worth a blocker: scripts/device/ios_build.dart:4 still mentions "Flutter 3.41 / Xcode 27.1" as a build failure. That is a historical measurement, so it is probably fine.

Overall risk: Low. I found no runtime bug. The changes are formatter churn, prefer_initializing_formals, build config for the example, and docs.

Merge recommendation: Fine to merge. I'd fix the two pigeons locks first, since a CI failure there is the one outcome I could not rule out. This is a recommendation only, not an approval.

Most important issues to fix

  1. Regenerate both pigeons/pubspec.lock files for the Dart 3.14 SDK constraint.
  2. Update or remove the stale cacheExtent comment and the blanket ignore in test/secure_region_test.dart.

Positives

  • Every review finding was addressed in one follow-up commit, with the reasons recorded in native-versions.json and CI.md.
  • The device harness takes its floor from the single source, native-versions.json, instead of another hard-coded copy.
  • Claims about JDK 25 now say what was measured and what is supported, rather than asserting a break.
    · branch fix/ci-stable-3.47

Comment thread test/secure_region_test.dart Outdated
@@ -10,7 +10,7 @@ import 'package:bugsee_flutter/src/secure/secure_region.dart';
// `cacheExtent` is deprecated on stable, but the floor (3.41.0) has no
// `scrollCacheExtent` yet.
// ignore_for_file: deprecated_member_use

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Severity: P3 Low
Problem: The comment says the floor (3.41.0) has no scrollCacheExtent, so the file-wide ignore_for_file: deprecated_member_use is needed. The floor is 3.50.0 now, so the premise is stale. The blanket ignore also hides any other deprecation in this 600+ line file.
Fix: Check whether 3.50.0 has scrollCacheExtent. If it does, migrate the three cacheExtent uses (lines ~367, 554, 641) and drop the ignore. If not, reword the comment to 3.50.0 and narrow the ignore to those lines.

… now that the floor has it

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I35475e9e12839a39d5f6ae381e710bd7bbac8df0
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 19s —— View job


PR review (re-run on push 4430776): Floor moves to Flutter 3.50 / Dart 3.14

This push adds one commit, 4430776. It replaces the three cacheExtent uses in test/secure_region_test.dart with scrollCacheExtent: const ScrollCacheExtent.pixels(...) and drops the file-wide ignore_for_file: deprecated_member_use. I read the diff and re-checked the open finding against the tree. I did not run builds or tests (no dart or flutter on this runner), and I pushed nothing.

Earlier finding fixed

  • test/secure_region_test.dart stale cacheExtent comment and blanket ignore: fixed. The comment and the ignore are gone, and the three call sites are migrated (lines ~364, 551, 638). I could not confirm that ScrollCacheExtent is reachable through material_ui. The author reports flutter test and analyze green on 3.50.0, which would cover it.

Earlier finding still open (P3)

  • pigeons/pubspec.lock:253 and packages/bugsee_flutter_feedback/pigeons/pubspec.lock:253: both still say dart: ">=3.11.0 <4.0.0", but both pubspec.yaml files say sdk: ^3.14.0.
    • Impact: the next dart pub get in those directories rewrites the sdks: entry. scripts/generate_pigeon.dart:77-81 runs pub get --enforce-lockfile there. I can't confirm whether pub counts a stale sdks: entry as a lock change. If it does, the bridge-codegen --check job fails. If it doesn't, the rewrite lands as churn in an unrelated PR.
    • Fix: run dart pub get in both pigeons/ directories and commit the locks. These files are not in the diff, so I couldn't attach an inline comment.

New findings: none.

Overall risk: Low. I found no runtime bug. The changes are formatter churn, prefer_initializing_formals, example build config, test-only API migration and docs.

Merge recommendation: Fine to merge. I'd refresh the two pigeons locks first, since a bridge-codegen CI failure is the one outcome I can't rule out. This is a recommendation only, not an approval.

Most important issue to fix

  1. Regenerate both pigeons/pubspec.lock files for the Dart 3.14 SDK constraint.

Positives

  • The cacheExtent fix removes the blanket ignore rather than narrowing it, so deprecations elsewhere in that large test file are visible again.
  • Review findings continue to be addressed one by one in small follow-up commits.
    · branch fix/ci-stable-3.47

…onstraint

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I8e6ac9602d3d28ce67ce0eb6d1010c39da2da0a8
@claude

claude Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 13s —— View job


PR review (re-run on push 709bb0f): Floor moves to Flutter 3.50 / Dart 3.14

This push adds one commit, 709bb0f. It changes one line in each of pigeons/pubspec.lock and packages/bugsee_flutter_feedback/pigeons/pubspec.lock: sdks: dart goes from >=3.11.0 <4.0.0 to >=3.14.0 <4.0.0. I checked the diff and the tree. I did not run builds or tests, and I pushed nothing.

Earlier finding fixed

  • Pigeons lock files: both locks now say >=3.14.0 <4.0.0, matching sdk: ^3.14.0 in both pigeons/pubspec.yaml files. The only change in the commit is that sdks: line, so the dependency set is untouched. A pub get --enforce-lockfile in scripts/generate_pigeon.dart should no longer see a stale SDK entry. I did not run it.

New findings: none. The commit touches only those two lock files.

Open findings: none. Every finding from the earlier reviews is now fixed in the tree.

Overall risk: Low. I found no runtime bug. The PR is formatter churn, prefer_initializing_formals, example build config, the material_ui migration, a test-only API migration, and docs. Pins and wrapper identity are still compared by the existing drift guards.

Merge recommendation: Fine to merge. Wait for CI to be green on both the floor and stable legs, since I did not run the builds. The iOS jobs on 3.50 and the project.pbxproj and AppFrameworkInfo.plist edits were not independently verified by me. This is a recommendation only, not an approval.

Most important issues to fix: none outstanding.

Positives

  • Every review finding was fixed in a small follow-up commit.
  • The device harness takes its floor from native-versions.json, so there is no extra hard-coded copy.
  • The lock files now agree with the pubspec SDK constraints.
    · branch fix/ci-stable-3.47

@krassx
krassx merged commit 5b0bb37 into nextgen Nov 18, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant