Skip to content

Adopt iOS SDK 7.0.1 - #22

Merged
krassx merged 2 commits into
nextgenfrom
chore/ios-7.0.1
Nov 10, 2026
Merged

krassx merged 2 commits into
nextgenfrom
chore/ios-7.0.1

Conversation

@krassx

@krassx krassx commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Moves the iOS pin from 7.0.0 to 7.0.1 (bugsee/spm 15553bd, bugsee/feedback-spm 0d20338).

  • native-versions.json plus every repeated copy (Package.swift x4, Package.resolved x2, harness sample banner); banner build 5c6b9d9db-8 is read from the string in the tag's binary, not from a run yet (stated in the provenance).
  • Re-extracted from origin/release@5c6b9d9db: report enums/timings/attachment limits, vh data request, option docs; iOS options manifest re-vendored. Values are unchanged; verify_option_manifests agrees with source (ios 71 keys).
  • Wrapper SPI headers (BugseeSPI.h) read: handler thread/timing semantics, secure-rect units (points) and lifecycle constants unchanged. No code change was needed.

Checks run locally: flutter analyze, flutter test (1357), generate_pigeon --check, wrapper XCTest (335), feedback wrapper XCTest (23), example iOS debug build. Not run: Android builds (untouched), device harness.

🤖 Generated with Claude Code

Pins bugsee/spm and bugsee/feedback-spm to 7.0.1 (15553bd, 0d20338), banner
build 5c6b9d9db-8 (read from the tag's binary). Re-extracted from the
release source origin/release@5c6b9d9db: report enums and timings, vh data
request constants, option docs; the iOS options manifest re-vendored
(only generatedAt/sdkVersion differ). Extracted values are unchanged.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Change-Id: I169a61e5d28357347633526086af1a53b11139ed
@claude

claude Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 33s —— View job


Review of PR #22: Adopt iOS SDK 7.0.1

I read the full diff against origin/nextgen and grepped the tree for leftover 7.0.0, 2b88480fa, bbfdda2 and 82054e7. I did not run any tests or builds (no Flutter, Xcode or SDK access here). The checks below come from reading the code and the diff.

No functional findings.

  • The pin is consistent across the places the guards compare:
    • native-versions.json (sdk, sdkBuild, spmRevision, feedbackSpmRevision)
    • the four Package.swift files (exact: "7.0.1")
    • the two Package.resolved files (spm 15553bd, feedback-spm 0d20338)
    • the harness banner fixture in test/device_harness_test.dart
    • the re-vendored ios.json manifest and the regenerated option_registry.g.dart header
  • No Dart, Swift, Objective-C or Java logic changes, so there is no behavioural regression surface in the wrapper. That depends on the PR's claim that the 7.0.1 SPI is unchanged, which I could not check against the private SDK source.
  • The two Package.resolved files are identical, as they were before.

Findings (all P3 Low, documentation drift)

.claude/CLAUDE.md says a doc claim about code (version, path, revision) must be checked against the code, and that docs change with the pin. These pages still describe the iOS pin as 7.0.0:

  1. P3 doc/verification.md:66, the "iOS SDK under test" row.

    • Problem: it states bugsee/spm 7.0.0 (revision bbfdda2, banner build:2b88480fa-7) and bugsee/feedback-spm 7.0.0 (82054e7) as the SDK under test. Those revisions no longer match native-versions.json.
    • Impact: a reader or a person running the harness gets a stale revision and banner build. The row is the only place in doc/ that names the revisions in effect.
    • Fix: update the row to 7.0.1 (15553bd, 5c6b9d9db-8, feedback 0d20338), or say explicitly that it is the pin before 7.0.1.
    • Related: the example banner at doc/verification.md:46 still shows ver:7.0.0 build:2b88480fa-7, and scripts/device/core/expectations.dart:58 has the same stale example in a comment.
  2. P3 packages/bugsee_flutter_feedback/doc/feedback.md:5.

    • Problem: it says bugsee/feedback-spm tag 7.0.0 (82054e7).
    • Impact: the feedback package's own doc now names the wrong tag and revision. packages/bugsee_flutter_feedback/CHANGELOG.md:7 ("feedback-spm 7.0.0") and packages/bugsee_flutter_feedback/README.md:98 repeat the 7.0.0 mention.
    • Fix: update the tag and revision to 7.0.1 (0d20338). Decide whether the CHANGELOG line should say 7.0.1 or stay as history. The feedback package is unreleased, so 7.0.1 is probably right.
  3. P3 doc/api-surface.md:4,11,28,96, doc/view-hierarchy.md:11,16, doc/attachments.md:9,24, doc/design-rules.md:35.

    • Problem: these still say "iOS 7.0.0 / origin/release@2b88480fa". The extracted facts (the vh data request, report timings and attachment limits) were re-extracted at 5c6b9d9db.
    • Impact: the "source read at" provenance in these tables no longer matches test/fixtures/*.json, which now say 5c6b9d9db.
    • Fix: re-label the tables to 7.0.1 or 5c6b9d9db where the content was re-read, and leave the old commit where it was read only at beta7 or 7.0.0. The 7.0.0 in code comments (BGSFlutterNetworkOps.h, endpoint.dart, pigeons/bridge.dart and the like) describes behaviour first seen in 7.0.0, so it is historical and fine as is. Note that pigeons/bridge.dart is the source for the generated Messages files, so changing it needs dart scripts/generate_pigeon.dart.

Notes, not defects

  • sdkBuild 5c6b9d9db-8 was read from the binary string, not from a run. The provenance says so, and the device harness check (workbook 9.1.1) will fail loudly if the banner differs. After merge, one iOS harness run would turn that into a measured value. I would not block on it.
  • test/option_manifests_test.dart:103-104 still uses 7.0.0 as a URL-template example. That is fine, because it tests the template and not the pin.

Summary

  1. Overall risk: Low. It is a pin bump with consistent version, revision and fixture updates, and no code change.
  2. Merge recommendation: Approve, ideally after fixing the doc drift in finding 1. Finding 2 can be done in the same change or as a follow-up.
  3. Most important issues: (a) doc/verification.md:66 names the wrong SDK revisions; (b) the feedback package doc and CHANGELOG still point at feedback-spm 7.0.0 / 82054e7.
  4. Positives:
    • The provenance strings are precise and honest about what was measured and what was read from the binary.
    • The PR description lists which checks were run and which were not.
    • The changed fixtures keep the drift guards meaningful.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 14 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b41f5a2c-188c-4d54-8727-6e566f2713d8
Commits

Reviewing files that changed from the base of the PR and between a167a2c and d3b5df1.

Files ignored due to path filters: 2

  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
Files selected for processing: 17

  • .claude/CLAUDE.md
  • CHANGELOG.md
  • PLAN.md
  • README.md
  • doc/README.md
  • doc/architecture.md
  • ios/bugsee_flutter/Package.swift
  • ios/wrapper_tests/Package.swift
  • lib/src/options/option_registry.g.dart
  • native-versions.json
  • packages/bugsee_flutter_feedback/ios/bugsee_flutter_feedback/Package.swift
  • packages/bugsee_flutter_feedback/ios/feedback_wrapper_tests/Package.swift
  • test/device_harness_test.dart
  • test/fixtures/data_requests.json
  • test/fixtures/option_manifests/docs.json
  • test/fixtures/option_manifests/ios.json
  • test/fixtures/report_enums.json
Summary

Summary by CodeRabbit

  • Chores
    • Updated the iOS native SDK version used by the Flutter integration from 7.0.0 to 7.0.1. The updated version is reflected consistently across the package and release information.
    • The Android native SDK version remains unchanged at 7.4.2.

The iOS native SDK pin changes from 7.0.0 to 7.0.1. Swift package dependencies, build and source provenance, generated manifest metadata, test fixtures, and documentation now reflect the updated version and build identity. Android version references remain unchanged.

Possibly related PRs

  • bugsee/bugsee-flutter#21: Updated the iOS SDK pin from 7.0.0-beta7 to 7.0.0, preceding this version update.
  • bugsee/bugsee-flutter#18: Established 7.x SDK references in the repository documentation that this change updates.
  • bugsee/bugsee-flutter#17: Introduced the device harness and SDK identity checks whose iOS version and build expectations are updated here.

Change: Other

Merge Risk: Minimal · previous review a167a

The SDK refresh is mergeable; the remaining documentation correction is low risk.

Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: adopting iOS SDK 7.0.1.
Description check Passed The description directly explains the iOS SDK pin update, affected dependencies, metadata changes, and validation performed.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 4 files. (13 skipped: 13 unsupported.)

Finishing Touches

Generate docstrings

  • Commit to this branch
  • Create a new PR
Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: baa04791-5de9-47f0-a805-ad715a39cc3a
Commits

Reviewing files that changed from the base of the PR and between a0c67a6 and a167a2c.

Files ignored due to path filters: 2

  • example/ios/Runner.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
  • example/ios/Runner.xcworkspace/xcshareddata/swiftpm/Package.resolved is excluded by !**/Package.resolved
Files selected for processing: 17

  • .claude/CLAUDE.md
  • CHANGELOG.md
  • PLAN.md
  • README.md
  • doc/README.md
  • doc/architecture.md
  • ios/bugsee_flutter/Package.swift
  • ios/wrapper_tests/Package.swift
  • lib/src/options/option_registry.g.dart
  • native-versions.json
  • packages/bugsee_flutter_feedback/ios/bugsee_flutter_feedback/Package.swift
  • packages/bugsee_flutter_feedback/ios/feedback_wrapper_tests/Package.swift
  • test/device_harness_test.dart
  • test/fixtures/data_requests.json
  • test/fixtures/option_manifests/docs.json
  • test/fixtures/option_manifests/ios.json
  • test/fixtures/report_enums.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@coderabbitai coderabbitai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Fix comments: Fix CodeRabbit comments on this PR

Comment thread doc/README.md Resolved
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WeiJxNbNUdWru1zs68bYV8
Change-Id: I6a7faa9c863110a870277dc8ef88731f71943436
@claude

claude Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Claude finished @krassx's task in 40s —— View job


Review of PR #22: Adopt iOS SDK 7.0.1 (re-review after push d3b5df1)

I diffed origin/nextgen...HEAD (19 files, 2 commits) and grepped the tree for 7.0.0, 2b88480fa, bbfdda2 and 82054e7. I did not run any tests or builds, because there is no Flutter, Xcode or SDK access here. I could not check the claim that the 7.0.1 SPI is unchanged, because the SDK source is private.

No functional findings. The PR changes no Dart, Swift, Objective-C or Java logic. The pin is consistent across native-versions.json, the four Package.swift files, the two Package.resolved files, the harness banner fixture, the re-vendored ios.json and the regenerated option_registry.g.dart.

Status of earlier findings

  • Fixed or accepted: the "doc pages still say iOS 7.0.0 / 2b88480fa" finding (api-surface.md, view-hierarchy.md, attachments.md, design-rules.md). d3b5df1 rewrote the doc/README.md paragraph to say each page keeps the revision it was read at, and names the pages that still cite 7.0.0 or beta7. That is a reasonable resolution.
  • Still open: doc/verification.md:66 and the feedback package docs, below.

Findings (all P3 Low, documentation drift)

I could not post these inline because the files are not in the PR diff, so they are listed here.

  1. P3 doc/verification.md:66 and :46 (open from the earlier review)

    • Problem: the "iOS SDK under test" row names bugsee/spm 7.0.0 (bbfdda2, build:2b88480fa-7) and feedback-spm 7.0.0 (82054e7). native-versions.json now pins 7.0.1 (15553bd, 5c6b9d9db-8, feedback 0d20338). Line 46 (9.1.1) still shows ver:7.0.0 build:2b88480fa-7 as the expected banner.
    • Impact: this is the one place in doc/ that records the iOS revisions the harness ran against. A reader gets the wrong revision and banner.
    • Fix: say which pin the evidence belongs to. For example: "pin now 7.0.1 (15553bd, 5c6b9d9db-8, not yet run); results below were taken at 7.0.0 and beta7". For line 46, use ver:<ios.sdk> build:<ios.sdkBuild> or the 7.0.1 values.
  2. P3 packages/bugsee_flutter_feedback/doc/feedback.md:5, plus CHANGELOG.md:7 (open from the earlier review)

    • Problem: feedback.md names bugsee/feedback-spm tag 7.0.0 (82054e7). The package's Package.swift files and native-versions.json now use 7.0.1 (0d20338). CHANGELOG.md:7 also says feedback-spm 7.0.0.
    • Impact: the feedback package's own doc and changelog name a dependency that is no longer the one it uses.
    • Fix: change the tag and revision to 7.0.1 (0d20338). The package is unreleased, so the CHANGELOG line should say 7.0.1 too. README.md:98 ("the iOS 7.0.0 chat") describes behaviour read at 7.0.0, so it can stay.
  3. P3 doc/migration-from-9x.md:19 (new)

    • Problem: the "Native SDKs" row for 10.0.0 says iOS 7.0.0. README.md and CHANGELOG.md in this PR now say 7.0.1.
    • Impact: this is the user-facing migration guide, so a 9.x user is told they get a different iOS SDK than the one that ships. Nothing in test/native_versions_test.dart covers this page.
    • Fix: change it to 7.0.1. Unlike the per-page "source read at" revisions that the new doc/README.md text explains, this row states the current pin.

Notes, not defects

  • sdkBuild 5c6b9d9db-8 was read from the binary, not from a run. The provenance says so, and the 9.1.1 harness check will fail if the banner differs. One iOS harness run after merge would turn it into a measured value.
  • The other remaining 7.0.0 mentions are historical code comments, test fixtures that exercise the URL template, and check_native_pins_test.dart sample data. They describe behaviour first seen in 7.0.0 or are test inputs, so I left them.

Summary

  1. Overall risk: Low. It is a pin bump with consistent version, revision and fixture updates, and no code change.
  2. Merge recommendation: Approve. I would fix the three doc items first, but none of them affects the build or behaviour.
  3. Most important issues: (a) doc/verification.md:66 and :46 name the wrong revisions; (b) the feedback package doc and CHANGELOG still point at feedback-spm 7.0.0; (c) doc/migration-from-9x.md:19 states the wrong iOS version to users.
  4. Positives:
    • The provenance strings say exactly what was measured and what was read from the binary.
    • The PR description lists which checks were run and which were not.
    • d3b5df1 handles the per-page source revisions sensibly.

@krassx
krassx merged commit b415a38 into nextgen Nov 10, 2026
@krassx
krassx deleted the chore/ios-7.0.1 branch November 11, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant