Skip to content

Add ADR 32 about breaking up Core project#826

Merged
justindbaur merged 4 commits into
mainfrom
add-adr-about-breaking-up-core
Jun 26, 2026
Merged

Add ADR 32 about breaking up Core project#826
justindbaur merged 4 commits into
mainfrom
add-adr-about-breaking-up-core

Conversation

@justindbaur

@justindbaur justindbaur commented Jun 25, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

Relates to: ARCH-16

📔 Objective

Adds an ADR proposing that the Core project should be decomposed into smaller feature scoped libraries.

In draft until #825 merges.

📸 Screenshots

Comment thread docs/architecture/adr/0032-break-up-core.md
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 25, 2026

Copy link
Copy Markdown

Deploying contributing-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: a7802ee
Status: ✅  Deploy successful!
Preview URL: https://3348ff3c.contributing-docs.pages.dev
Branch Preview URL: https://add-adr-about-breaking-up-co.contributing-docs.pages.dev

View logs

@justindbaur justindbaur marked this pull request as ready for review June 26, 2026 17:04
@justindbaur justindbaur requested a review from a team as a code owner June 26, 2026 17:04
@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR adds ADR 0032 proposing the decomposition of the server Core project into feature-scoped libraries. The document follows the established ADR structure (Context, Considered options, Decision outcome, consequences, Plan), uses frontmatter consistent with ADR 0031, and is auto-registered via the DocCardList index. The bitwarden_license layout example requested in the existing review thread has been added.

Code Review Details

No findings. This is a documentation-only change (a single prose ADR). The file naming, frontmatter, cross-references to ADR 0031, and directory placement all match repository conventions. The illustrative C# examples are syntactically valid, and the prior reviewer feedback about a bitwarden_license example has been addressed.

@theMickster theMickster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor but important adjustment. Dealers choice on how to implement said change.

Comment thread docs/architecture/adr/0032-break-up-core.md
@justindbaur justindbaur merged commit 2795c5e into main Jun 26, 2026
27 checks passed
@justindbaur justindbaur deleted the add-adr-about-breaking-up-core branch June 26, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants