Add ADR 31 about minimal API adoption#825
Conversation
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the addition of ADR 0031 proposing adoption of .NET minimal APIs for new server endpoints in feature-scoped libraries. The new ADR follows the established frontmatter and section structure (Context, Considered options, Decision outcome, Consequences, Plan), auto-registers via Code Review DetailsNo findings. |
|
|
||
| ### Plan | ||
|
|
||
| A new `ENDPOINT_LIBRARY.md` file will be written in a new `src/Libraries` directory. This document |
There was a problem hiding this comment.
Do we want a formal ADR for the folder changes to server?
There was a problem hiding this comment.
I have another ADR I want to write about breaking up Core that I think that would fit in better. I can write that first or I can just temporarily remove the src/Libraries part for now and this doc can go straight in src.
theMickster
left a comment
There was a problem hiding this comment.
Handful of suggestions to strengthen the prose in the document.
One noted significant concern about a mixed codebase of controllers of different types for an indefinite timeframe.
Co-authored-by: Mick Letofsky <mletofsky@bitwarden.com>
Deploying contributing-docs with
|
| Latest commit: |
a104a7e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f3504199.contributing-docs.pages.dev |
| Branch Preview URL: | https://add-minimal-apis-adr.contributing-docs.pages.dev |
🎟️ Tracking
Relates to: ARCH-16
📔 Objective
Adds an ADR proposing that all new server endpoints be built using .NET minimal APIs in feature-scoped libraries, rather than continuing to add to the existing controller-based approach.
The ADR covers:
Add[Feature]Services+Map[Feature]Endpointswith a code example showing side-by-side usage with existing controllersActionFilterAttributesneeding rewrite before affected controllers can be migrated📸 Screenshots