Repository navigation
fix: keep timeline chip counts in step with the rows shown - #78
Merged
Merged
Conversation
The card read chain statuses first and the rows later, so a job that finished in between left In flight counted next to a completed row, and polling stopped with the stale count. Counts for the page chains now come from the same rows, and the fingerprint is read before them. Experience Cloud targets are dropped from the card until access is scoped to the record. The docs say AsyncResultAccess is View All. Refs #77
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚀 Salesforce CI⏭️ Deployment skippedAn earlier step failed (scratch org creation or Dev Hub authorization), so nothing was deployed. Check the workflow logs. 📦 Workflow run, logs and artifacts 🤖 Automated comment by Salesforce CI |
2 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In flight 1can't sit next to a completed row. The fingerprint is read before the rows, so a change in between shows up on the next poll.shouldCountAPageChainByTheRowsReadForThePage: status snapshot taken while a step isENQUEUED, the step then finishes, counts follow the rows. Rows of another record are ignored.Async Jobs, and the claims from the 3.2.0 notes and docs. Tested on a site as a Customer Community user: View All lets them open results of records they can't see, andloadreturns chains for any record id. Fix is tracked in Record-scoped access for the Async Jobs card, then Experience Cloud #77.AsyncResultAccessis View All, so the card is not a sharing boundary yet.Why
Found while testing the 3.2.0 package before promote: on the installed card, a row showed
COMPLETED, statusIdle, chipsIn flight 1, Completed 0, until reload.Test plan
bash dev/verify/verify.sh staticpassed (prettier + eslint + PMD, Jest 213/213)bash dev/verify/verify.sh fullpassed (441/441, coverage 97%)bash dev/verify/verify.sh nspassedFiles
force-app/main/default/classes/timeline/AsyncJobTimelineChains.clsforce-app/main/default/classes/timeline/AsyncJobTimelineLoader.clsforce-app/main/default/classes/timeline/AsyncJobTimelineControllerTest.clsforce-app/main/default/lwc/asyncJobTimeline/asyncJobTimeline.js-meta.xmlrelease-notes/v3.2.0.mdwebsite/features/job-timeline.md,website/introduction/packaged-install.md,website/ai-usage.mdRefs #77