Repository navigation
fix: run the new chain count test as the operator user - #79
Merged
Merged
Conversation
The package version build runs tests as its own user, and the WITH USER_MODE chain query threw 'Variable does not exist: tmpVar4' there. Running the snapshot as the operator, like the other timeline tests, fixes the build.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🚀 Salesforce CI⏭️ Deployment skippedAn earlier step failed (scratch org creation or Dev Hub authorization), so nothing was deployed. Check the workflow logs. 📦 Workflow run, logs and artifacts 🤖 Automated comment by Salesforce CI |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shouldCountAPageChainByTheRowsReadForThePagebuilds itsAsyncJobTimelineChainssnapshot insideSystem.runAs(operator()), like the other timeline tests.Why
The v3.2.0 package version build failed on this test from #78. The build runs Apex tests as its own user, and the
WITH USER_MODEchain query threwSystem.QueryException: Variable does not exist: tmpVar4there. It never failed in a scratch org, from source or from the globalized copy. With therunAs, a package build from this branch succeeded (99% coverage).Test-only change, no production code touched.
Test plan
bash dev/verify/verify.sh allpassed (Jest 213/213, mock 66/66, full 441/441 at 97%, ns green)Files
force-app/main/default/classes/timeline/AsyncJobTimelineControllerTest.cls