Skip to content

Remove dead JSONRPC server_shutdown handler #13578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masaori335 wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −8
Open

Remove dead JSONRPC server_shutdown handler #13578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion include/mgmt/rpc/handlers/server/Server.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ namespace rpc::handlers::server
{
swoc::Rv<YAML::Node> server_start_drain(std::string_view const &id, YAML::Node const &params);
swoc::Rv<YAML::Node> server_stop_drain(std::string_view const &id, YAML::Node const &);
void server_shutdown(YAML::Node const &);
swoc::Rv<YAML::Node> get_server_status(std::string_view const &id, YAML::Node const &);
swoc::Rv<YAML::Node> get_connection_tracker_info(std::string_view const &id, YAML::Node const &params);

Expand Down
7 changes: 0 additions & 7 deletions src/mgmt/rpc/handlers/server/Server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
limitations under the License.
*/

#include "../../../../iocore/cache/P_CacheDir.h"
#include "iocore/eventsystem/EventProcessor.h"
#include "iocore/net/ConnectionTracker.h"
#include "mgmt/rpc/handlers/server/Server.h"
Expand Down Expand Up @@ -176,12 +175,6 @@ server_stop_drain(std::string_view const & /* id ATS_UNUSED */, YAML::Node const
return resp;
}

void
server_shutdown(YAML::Node const &)
{
sync_cache_dir_on_shutdown();
}

swoc::Rv<YAML::Node>
get_server_status(std::string_view const & /* params ATS_UNUSED */, YAML::Node const & /* params ATS_UNUSED */)
{
Expand Down