Remove dead JSONRPC server_shutdown handler - #13578
Open
masaori335 wants to merge 1 commit into
Open
Conversation
Never registered nor called since it was added in apache#7478, and its void(YAML::Node) signature never matched the method handler shape it sat among. Shutdown already syncs the cache dir from the event thread in traffic_server.cc; doing it from an RPC thread would race the dir writers. Dropping it also removes mgmt's relative-path include of iocore's private P_CacheDir.h.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused JSONRPC handler (server_shutdown) from the management RPC server handlers, avoiding an unregistered/mismatched handler signature and eliminating an unnecessary dependency on iocore cache internals from mgmt.
Changes:
- Removed the dead
server_shutdownhandler implementation and its declaration. - Dropped the mgmt-side include of
P_CacheDir.hthat was only used by the removed handler.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/mgmt/rpc/handlers/server/Server.cc | Removes the unused shutdown handler and the private cache header include. |
| include/mgmt/rpc/handlers/server/Server.h | Removes the corresponding handler declaration from the public header. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JosiahWI
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Never registered nor called since it was added in #7478, and its void(YAML::Node) signature never matched the method handler shape it sat among. Shutdown already syncs the cache dir from the event thread in traffic_server.cc; doing it from an RPC thread would race the dir writers. Dropping it also removes mgmt's relative-path include of iocore's private P_CacheDir.h.