Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions crates/paimon/src/table/format_read_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,13 @@ impl<'a> FormatReadBuilder<'a> {
}

pub(crate) fn new_read(&self) -> Result<TableRead<'a>> {
// Fail closed here as well as in `FormatTableScan::plan`, so a caller that
// goes straight to `new_read` cannot silently read unfiltered rows.
if self.row_ranges.is_some() {
return Err(crate::Error::Unsupported {
message: "Row ranges are not supported for format tables".to_string(),
});
}
let core_options = self.table.schema().core_options();
core_options.ensure_read_authorized()?;
let read_type = match self.resolve_read_type()? {
Expand Down
9 changes: 9 additions & 0 deletions crates/paimon/src/table/read_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -819,6 +819,15 @@ mod tests {
assert!(
matches!(error, crate::Error::Unsupported { ref message } if message.contains("format tables"))
);

// `new_read` must reject too: a caller that skips planning would otherwise
// read every row instead of the requested ranges.
let mut builder = table.new_read_builder();
builder.with_row_ranges(Vec::new());
let error = builder.new_read().unwrap_err();
assert!(
matches!(error, crate::Error::Unsupported { ref message } if message.contains("format tables"))
);
}

fn dv_pk_table(table_path: &str, merge_engine: &str) -> Table {
Expand Down
Loading